kernel/git/next/linux-next.git/drivers/crypto/qcom-rng.c, branch masterThe linux-next integration testing treehttps://git.rulkc.org/pub/scm/linux/kernel/git/next/linux-next.git/atom?h=master2026-07-05T05:22:35+00:00hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/2026-07-05T05:22:35+00:00Eric Biggersebiggers@kernel.org2026-06-08T17:58:48+00:00urn:sha1:6727c44461f788bb49a37875fbc70654e8db30b2
Since this file just implements a hwrng driver, move it into
drivers/char/hw_random/. Rename the kconfig option accordingly as well.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - Remove crypto_rng interface2026-07-05T05:19:52+00:00Eric Biggersebiggers@kernel.org2026-06-08T17:58:47+00:00urn:sha1:2ecdf5c9910e20f73639bc322f0518a3439d17c0
qcom-rng.c exposes the same hardware through two completely separate
interfaces, crypto_rng and hwrng. However, the implementation of this
is buggy because it permits generation operations from these interfaces
to run concurrently with each other, accessing the same registers. That
is, qcom_rng_generate() synchronizes with itself but not with
qcom_hwrng_read(). This results in potential repetition of output from
the RNG, output of non-random values, etc.
Fortunately, there's actually no point in hardware RNG drivers
implementing the crypto_rng interface. It's not actually used by
anything besides the "rng" algorithm type of AF_ALG, which in turn is
not actually used in practice. Other crypto_rng hardware drivers are
likewise being phased out, leaving just the hwrng support.
Thus, remove it to simplify the code and avoid conflict (and confusion)
with the hwrng interface which is the one that actually matters.
Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - Allow zero as a random number2026-07-05T05:19:52+00:00Eric Biggersebiggers@kernel.org2026-06-08T17:58:46+00:00urn:sha1:4ef04bdc0c9f98836d1638be516f6bf1bad55f69
Zero is a valid random number and needs to be allowed. Otherwise the
output is distinguishable from random.
Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - Enable clock in hwrng case2026-07-05T05:19:52+00:00Eric Biggersebiggers@kernel.org2026-06-08T17:58:45+00:00urn:sha1:0fd97bbda2842d7dcccee599ac2c0e9554bdddbc
Fix qcom-rng.c to enable the clock before accessing the hardware.
Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: drivers - remove of_match_ptr from OF match tables2026-05-22T12:25:30+00:00Thorsten Blumthorsten.blum@linux.dev2026-05-16T18:23:36+00:00urn:sha1:2b7b16c905b08a4cd28cbb2809ee38a78bfe0489
Drop of_match_ptr() because OF matching is stubbed out when CONFIG_OF=n.
Indent bcm_spu_pdriver.driver and its members while at it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: drivers - Switch back to struct platform_driver::remove()2024-10-19T00:44:30+00:00Uwe Kleine-Königu.kleine-koenig@baylibre.com2024-10-07T20:58:06+00:00urn:sha1:f51c527f17c534143f6f6b769be8e078b411b20c
After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.
Convert all platform drivers below drivers/crypto to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - rename *_of_data to *_match_data2024-09-13T10:26:52+00:00Brian Masneybmasney@redhat.com2024-09-06T00:25:21+00:00urn:sha1:f29ca8f762d19f7e26913ee49325806cb55f2d8f
The qcom-rng driver supports both ACPI and device tree based systems.
Let's rename all instances of *of_data to *match_data so that it's
not implied that this driver only supports device tree-based systems.
Signed-off-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - fix support for ACPI-based systems2024-09-13T10:26:52+00:00Brian Masneybmasney@redhat.com2024-09-06T00:25:20+00:00urn:sha1:3e87031a6ce68f13722155497cd511a00b56a2ae
The qcom-rng driver supports both ACPI and device tree-based systems.
ACPI support was broken when the hw_random interface support was added.
Let's go ahead and fix this by adding the appropriate driver data to the
ACPI match table, and change the of_device_get_match_data() call to
device_get_match_data() so that it will also work on ACPI-based systems.
This fix was boot tested on a Qualcomm Amberwing server (ACPI based) and
on a Qualcomm SA8775p Automotive Development Board (DT based). I also
verified that qcom-rng shows up in /proc/crypto on both systems.
Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Reported-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Closes: https://lore.kernel.org/linux-arm-msm/20240828184019.GA21181@eaf/
Cc: stable@vger.kernel.org
Signed-off-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - Convert to platform remove callback returning void2023-10-27T10:04:26+00:00Uwe Kleine-Königu.kleine-koenig@pengutronix.de2023-10-20T07:55:55+00:00urn:sha1:37548f1dd35de924bb9a1b1dafdb4d4bffd42ddd
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: qcom-rng - Add hw_random interface support2023-10-13T10:30:54+00:00Om Prakash Singhquic_omprsing@quicinc.com2023-10-03T07:10:21+00:00urn:sha1:f29cd5bb64c258f29b4c49452532481f50eb43ca
Add hw_random interface support in qcom-rng driver as new IP block
in Qualcomm SoC has inbuilt NIST SP800 90B compliant entropic source
to generate true random number.
Keeping current rng_alg interface as well for random number generation
using Kernel Crypto API.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>