kernel/git/next/linux-next.git/drivers/crypto/sahara.c, branch master

crypto: drivers - Remove redundant dev_err()/dev_err_probe()

2026-07-27T00:29:27+00:00

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang Signed-off-by: Herbert Xu

crypto: drivers - Switch back to struct platform_driver::remove()

2024-10-19T00:44:30+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/crypto to use .remove(), with the eventual goal to drop struct platform_driver::remove_new(). As .remove() and .remove_new() have the same prototypes, conversion is done by just changing the structure member name in the driver initializer. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

crypto: sahara - use 'time_left' variable with wait_for_completion_timeout()

2024-05-10T09:15:25+00:00

There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_for_completion_timeout() causing patterns like: timeout = wait_for_completion_timeout(...) if (!timeout) return -ETIMEDOUT; with all kinds of permutations. Use 'time_left' as a variable to make the code self explaining. Signed-off-by: Wolfram Sang Signed-off-by: Herbert Xu

crypto: sahara - add support for crypto_engine

2023-12-29T03:25:56+00:00

Convert sahara driver to use crypto_engine, rather than doing manual queue management. Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - remove error message for bad aes request size

2023-12-29T03:25:56+00:00

Do not spam the kernel log with unnecessary error messages when processing requests that aren't a multiple of AES block size. Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - remove unnecessary NULL assignments

2023-12-29T03:25:56+00:00

Remove unnecessary 'dev_ptr' NULL assignments in sahara_remove() and sahara_probe(). Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - remove 'active' flag from sahara_aes_reqctx struct

2023-12-29T03:25:56+00:00

The 'active' flag is only used to indirectly set the 'first' flag. Drop the 'active' flag and set 'first' directly in sahara_sha_init(). Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - use dev_err_probe()

2023-12-29T03:25:56+00:00

Switch to use dev_err_probe() to simplify the error paths and unify message template. While at it, also remove explicit error messages from every potential -ENOMEM. Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - use devm_clk_get_enabled()

2023-12-29T03:25:56+00:00

Use devm_clk_get_enabled() helper to simplify probe/remove code. Also, use dev_err_probe() for error reporting. Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu

crypto: sahara - use BIT() macro

2023-12-29T03:25:56+00:00

Where applicable, use BIT() macro instead of shift operation to improve readability. No functional change. Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu