kernel/git/next/linux-next.git/drivers/hsi, branch akpm

HSI: omap_ssi: Fix refcount leak in ssi_probe

2022-04-12T09:58:54+00:00

When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly release the node. Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Miaoqian Lin Signed-off-by: Sebastian Reichel

HSI: clients: remove duplicate assignment

2022-04-12T09:58:51+00:00

netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed, no need to repeat assignment. Signed-off-by: Wang Qing Signed-off-by: Sebastian Reichel

HSI: core: Fix return freed object in hsi_new_client

2021-11-25T23:27:06+00:00

cl is freed on error of calling device_register, but this object is return later, which will cause uaf issue. Fix it by return NULL on error. Signed-off-by: Chengfeng Ye Signed-off-by: Sebastian Reichel

Merge tag 'hsi-for-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi

2021-11-04T20:56:55+00:00

Pull HSI update from Sebastian Reichel: "cmt_speech: unmark comments as kernel-doc" * tag 'hsi-for-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi: HSI: cmt_speech: unmark comments as kernel-doc

net: remove single-byte netdev->dev_addr writes

2021-10-13T17:03:59+00:00

Make the drivers which use single-byte netdev addresses (netdev->addr_len == 1) use the appropriate address setting helpers. arcnet copies from int variables and io reads a lot, so add a helper for arcnet drivers to use. Similar helper could be reused for phonet and appletalk but there isn't any good central location where we could put it, and netdevice.h is already very crowded. Acked-by: Sebastian Reichel # for HSI Link: https://lore.kernel.org/r/20211012142757.4124842-1-kuba@kernel.org Signed-off-by: Jakub Kicinski

HSI: cmt_speech: unmark comments as kernel-doc

2021-10-02T13:40:50+00:00

Fix build warnings from the kernel test robot: drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Block until pending data transfers have completed. Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Aditya Srivastava Acked-by: Pavel Machek Signed-off-by: Sebastian Reichel

HSI: core: fix resource leaks in hsi_add_client_from_dt()

2021-04-15T22:14:49+00:00

If some of the allocations fail between the dev_set_name() and the device_register() then the name will not be freed. Fix this by moving dev_set_name() directly in front of the call to device_register(). Fixes: a2aa24734d9d ("HSI: Add common DT binding for HSI client devices") Signed-off-by: Dan Carpenter Reviewed-by: Jason Gunthorpe Signed-off-by: Sebastian Reichel

HSI: Fix PM usage counter unbalance in ssi_hw_init

2020-12-29T22:57:06+00:00

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. We fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: b209e047bc743 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Zhang Qilong Signed-off-by: Sebastian Reichel

HSI: core: fix a kernel-doc markup

2020-12-02T21:35:44+00:00

A function has a different name between their prototype and its kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sebastian Reichel

HSI: omap_ssi: Don't jump to free ID in ssi_add_controller()

2020-11-28T23:39:29+00:00

In current code, it jumps to ida_simple_remove() when ida_simple_get() failes to allocate an ID. Just return to fix it. Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module") Signed-off-by: Jing Xiangfeng Signed-off-by: Sebastian Reichel