kernel/git/next/linux-next.git/drivers/net/ipa, branch akpm-base

net: ipa: remove unexpected word "the"

2022-06-23T01:20:26+00:00

there is an unexpected word "the" in the comments that need to be removed Signed-off-by: Jiang Jian Reviewed-by: Alex Elder Link: https://lore.kernel.org/r/20220621085001.61320-1-jiangjian@cdjrlc.com Signed-off-by: Jakub Kicinski

net: ipa: move more code out of gsi_channel_update()

2022-06-17T03:44:04+00:00

Move the processing done for TX channels in gsi_channel_update() into gsi_evt_ring_rx_update(). The called function is called for both RX and TX channels, so rename it to be gsi_evt_ring_update(). As a result, this code no longer assumes events in an event ring are associated with just one channel. Because all events in a ring are handled in that function, we can move the call to gsi_trans_move_complete() there, and can ring the event ring doorbell there as well after all new events in the ring have been processed. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: call gsi_evt_ring_rx_update() unconditionally

2022-06-17T03:44:04+00:00

When an RX transaction completes, we update the trans->len field to contain the actual number of bytes received. This is done in a loop in gsi_evt_ring_rx_update(). Change that function so it checks the data transfer direction recorded in the transaction, and only updates trans->len for RX transfers. Then call it unconditionally. This means events for TX endpoints will run through the loop without otherwise doing anything, but this will change shortly. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: pass GSI pointer to gsi_evt_ring_rx_update()

2022-06-17T03:44:03+00:00

The only reason the event ring's channel pointer is needed in gsi_evt_ring_rx_update() is so we can get at its GSI pointer. We can pass the GSI pointer as an argument, along with the event ring ID, and thereby avoid using the event ring channel pointer. This is another step toward no longer assuming an event ring services a single channel. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: don't pass channel when mapping transaction

2022-06-17T03:44:03+00:00

Change gsi_channel_trans_map() so it derives the channel used from the transaction. Pass the index of the *first* TRE used by the transaction, and have the called function account for the fact that the last one used is what's important. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: don't assume one channel per event ring

2022-06-17T03:44:03+00:00

In gsi_evt_ring_rx_update(), use gsi_event_trans() repeatedly to find the transaction associated with an event, rather than assuming consecutive events are associated with the same channel. This removes the only caller of gsi_trans_pool_next(), so get rid of it. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: rework gsi_channel_tx_update()

2022-06-15T08:07:58+00:00

Rename gsi_channel_tx_update() to be gsi_trans_tx_completed(), and pass it just the transaction pointer, deriving the channel from the transaction. Update the comments above the function to provide a more concise description of how statistics for TX endpoints are maintained and used. Signed-off-by: Alex Elder Signed-off-by: David S. Miller

net: ipa: stop counting total RX bytes and transactions

2022-06-15T08:07:58+00:00

In gsi_evt_ring_rx_update(), we update each transaction so its len field reflects the actual number of bytes received. In the process, the total number of transactions and bytes processed on the channel are summed, and added to a running total for the channel. But we don't actually use those running totals for RX endpoints. They're maintained for TX channels to support CoDel when they are associated with a "real" network device. So stop maintaining these totals for RX endpoints, and update the comment where the fields are defined to make it clear they're only valid for TX channels. Signed-off-by: Alex Elder Signed-off-by: David S. Miller

net: ipa: simplify TX completion statistics

2022-06-15T08:07:58+00:00

When a TX request is issued, its channel's accumulated byte and transaction counts are recorded. This currently does *not* take into account the transaction being committed. Later, when the transaction completes, the number of bytes and transactions that have completed since the transaction was committed are reported to the network stack. The transaction and its byte count are accounted for at that time. Instead, record the transaction and its bytes in the counts recorded at commit time. This avoids the need to do so when the transaction completes, and provides a (small) simplification of that code. Signed-off-by: Alex Elder Signed-off-by: David S. Miller

net: ipa: introduce gsi_trans_tx_committed()

2022-06-15T08:07:58+00:00

Create a new function that encapsulates recording information needed for TX channel statistics when a transaction is committed. Record the accumulated length in the transaction before the call (for both RX and TX), so it can be used when updating TX statistics. Signed-off-by: Alex Elder Signed-off-by: David S. Miller