kernel/git/next/linux-next.git/drivers/ntb/test, branch akpm

drivers/ntb/test: avoid 64-bit modulus operation

2022-06-27T16:30:06+00:00

Redefine RESCHEDULE_RATIO to a closest power of 2 so that the following code in the perf_run_latency /* Avoid processor soft lock-ups */ if (!(pthr->tries % RESCHEDULE_RATIO)) schedule(); doesn't do 64-bit modulus operation. This fixes the following build failures on 32-bit architectures visible in linux-next: ERROR: modpost: "__umoddi3" [drivers/ntb/test/ntb_perf.ko] undefined! Fixes: dc150dfb081f ("ntb_perf: extend with burst latency measurement") Signed-off-by: Max Filippov Signed-off-by: Jon Mason

ntb_perf: extend with doorbell latency measurement

2022-06-20T13:16:40+00:00

Doorbell latency is a delay between start to ring an NTB doorbell and receiving the confirmation. The remote system needs to be run in server mode beforehand. Then the server waits for a doorbell event and immediately rings self doorbell to confirm. Thanks-to: Guo Zhengkui Signed-off-by: Alexander Fomichev Reviewed-by: Dave Jiang Signed-off-by: Jon Mason

ntb_perf: extend with poll latency measurement

2022-06-20T13:16:36+00:00

Poll latency is a delay between start to send 1 byte to the remote system and receiving the confirmation. The remote system needs to be run in server mode beforehand. Then the server polls the input buffer and on receiving data immediately sends the confirmation back. Signed-off-by: Alexander Fomichev Reviewed-by: Dave Jiang Signed-off-by: Jon Mason

ntb_perf: extend with burst latency measurement

2022-06-20T13:16:26+00:00

Burst latency is a delay between start to send 1 byte to the remote system and hardware readiness to send another byte. The measurement performed within bandwidth test procedure. The DMA Engine is off. Data integrity is not checked. This mode can be disabled by 'perf_latency=N' module parameter. Signed-off-by: Alexander Fomichev Reviewed-by: Dave Jiang Signed-off-by: Jon Mason

ntb: ntb_pingpong: remove redundant initialization of variables msg_data and spad_data

2021-09-05T22:04:46+00:00

The variables msg_data and spad_data are being initialized with values that are never read, they are being updated later on. The initializations are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Acked-by: Serge Semin Signed-off-by: Jon Mason

NTB: perf: Fix an error code in perf_setup_inbuf()

2021-09-04T22:36:04+00:00

When the function IS_ALIGNED() returns false, the value of ret is 0. So, we set ret to -EINVAL to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Serge Semin Signed-off-by: Jon Mason

NTB: Fix an error code in ntb_msit_probe()

2021-09-04T22:36:04+00:00

When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Logan Gunthorpe Signed-off-by: Jon Mason

NTB: Use struct_size() helper in devm_kzalloc()

2020-08-24T14:58:06+00:00

Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary variable _struct_size_. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Logan Gunthorpe Signed-off-by: Jon Mason

NTB: perf: Fix race condition when run with ntb_test

2020-06-06T00:02:09+00:00

When running ntb_test, the script tries to run the ntb_perf test immediately after probing the modules. Since adding multi-port support, this fails seeing the new initialization procedure in ntb_perf can not complete instantly. To fix this we add a completion which is waited on when a test is started. In this way, run can be written any time after the module is loaded and it will wait for the initialization to complete instead of sending an error. Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Acked-by: Allen Hubbe Tested-by: Alexander Fomichev Signed-off-by: Jon Mason

NTB: perf: Fix support for hardware that doesn't have port numbers

2020-06-06T00:02:09+00:00

Legacy drivers do not have port numbers (but is reliably only two ports) and was broken by the recent commit that added mult-port support to ntb_perf. This is especially important to support the cross link topology which is perfectly symmetric and cannot assign unique port numbers easily. Hardware that returns zero for both the local port and the peer should just always use gidx=0 for the only peer. Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Acked-by: Allen Hubbe Tested-by: Alexander Fomichev Signed-off-by: Jon Mason