summaryrefslogtreecommitdiff
path: root/drivers
AgeCommit message (Collapse)Author
2026-07-07staging: rtl8723bs: remove redundant rsp_allocated_bufDevansh Soni
The original code allocated extra memory and manually aligned the rsp_buf pointer to a 4-byte boundary, however kzalloc() guarantees a minimum of 8-byte alignment so this was unnecessary. Also, because the pointer was shifted, the original pointer had to be stored in rsp_allocated_buf just so it could be passed to kfree() later. Remove the redundant alignment math, remove the extra 4 bytes of padding from kzalloc() call, and assign memory directly to rsp_buf. This allows us to remove the rsp_allocated_buf variable from cmd_priv struct. Suggested-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Devansh Soni <devanshsoni874@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260617123853.63022-1-devanshsoni874@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Fix comment style issues in header filesSubhrojyoti Bala
Fix various comment style issues in wlan_bssdef.h and rtw_mlme.h to comply with kernel coding style: - Use proper multi-line comment format with trailing */ on its own line - Remove extra spaces after /* in single-line comments No functional change. Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260617064150.16078-3-subhrojyoti0609@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Fix indentation in enum in rtw_mlme.hSubhrojyoti Bala
Enum members were missing tab indentation. Add proper tab indent to align with kernel coding style. No functional change. Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com> Link: https://patch.msgid.link/20260617064150.16078-2-subhrojyoti0609@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Fix missing spaces around operatorsMoksh Panicker
Add missing spaces around arithmetic and bitwise operators ('+', '-', '&') in the rtl8723bs staging driver across multiple files. These were flagged by checkpatch.pl with: CHECK: spaces preferred around that 'X' (ctx:VxV) Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260615082538.12007-1-mokshpanicker.7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove references to nonexistent CONFIG_IOCTL_CFG80211 ↵Ethan Nelson-Moore
option Comments in the rtl8723bs driver contain references to CONFIG_IOCTL_CFG80211, which does not exist in the kernel. Remove these references. Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file. Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com> Link: https://patch.msgid.link/20260613231514.145336-1-enelsonmoore@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove reference to nonexistent CONFIG_SDIO_HCI optionEthan Nelson-Moore
A comment in the rtl8723bs driver contains a reference to CONFIG_SDIO_HCI, which does not exist in the kernel. Remove it. Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file. Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com> Link: https://patch.msgid.link/20260613183055.10425-1-enelsonmoore@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in rtl8723bs_recv.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-7-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in rtl8723b_hal_init.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-6-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in HalPhyRf_8723B.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-4-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in hal_com.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-3-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in hal_btcoex.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-2-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in HalBtc8723b2Ant.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-1-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused channel format/arg macrosChen-Yu Yeh
CHAN_FMT and CHAN_ARG are defined but never used anywhere in the driver. Most of their content is commented-out dead code. Remove them. This also fixes a checkpatch error: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com> Link: https://patch.msgid.link/20260611081644.1553264-1-chenyou910331@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused netdev format/arg macrosChen-Yu Yeh
NDEV_ARG, FUNC_NDEV_FMT and FUNC_NDEV_ARG are defined but never used anywhere in the driver. Remove them. This also fixes a checkpatch error: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com> Link: https://patch.msgid.link/20260611074613.1550984-1-chenyou910331@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove references to nonexistent CONFIG_IEEE80211W optionEthan Nelson-Moore
Comments in the rtl8723bs driver contain many references to CONFIG_IEEE80211W, which does not exist in the kernel (though it does exist in wpa_supplicant, where this code was likely also used). Remove them. Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file. Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com> Link: https://patch.msgid.link/20260611014430.437534-1-enelsonmoore@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: core: avoid NULL pointer dereference in c2h_wk_callbackNikoloz Bakuradze
kmalloc(16, GFP_ATOMIC) in c2h_wk_callback() could in theory return2 NULL, which would then be dereferenced in rtw_hal_c2h_valid(). A 16-byte allocation effectively cannot fail in practice, but add an else continue; to the guard so the failure path exits the iteration cleanly to make the code more robust. Signed-off-by: Nikoloz Bakuradze <nbakuradze28@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Link: https://patch.msgid.link/20260610164755.49626-1-nbakuradze28@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Drop unused parameter from rtw_sdio_if1_init()Uwe Kleine-König
The function doesn't use the pdid parameter, so drop that and adapt the only caller accordingly. Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org> Link: https://patch.msgid.link/23949de4c5f10e78a4bd85e333d7acd47b2f66b7.1781109707.git.ukleinek@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723: remove multiple blank lines in rtw_security.cAndrea Frasson
Remove unnecessary multiple blank lines. Fix 5 checkpatch.pl checks in rtw_security.c of the type: - CHECK: Please don't use multiple blank lines Signed-off-by: Andrea Frasson <andreafrasson1995@gmail.com> Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com> Link: https://patch.msgid.link/aiRL4dekV140SPGw@frassi Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: add braces to resolve checkpatchDalvin-Ehinoma Noah Aiguobas
Resolved checkpatch finding by adding braces as shown in styleguide. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/aiG4aDh2czwJ2-bf@koolguy Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unnecessary parenthesesEugene Mavick
Remove unnecessary parantheses around &(foo->bar) type statements to improve code readability Signed-off-by: Eugene Mavick <m@mavick.dev> Link: https://patch.msgid.link/20260604095617.852425-1-m@mavick.dev Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused network_type_in_use fieldCong Nguyen
The network_type_in_use member of struct wlan_bssid_ex is write-only: nothing in the driver ever reads it. It is assigned in three places, none of which feed anything: - collect_bss_info() hard-codes it to Ndis802_11OFDM24 for every parsed beacon/probe response, regardless of the network's actual band or rates (it is even wrong for 5 GHz APs, which the same function explicitly handles). - rtw_check_beacon_data() and rtw_update_registrypriv_dev_network() derive it from the wireless mode via a switch, but the result is likewise never consumed. The live PHY classification the driver actually acts on is kept in wlan_network.network_type (the WIRELESS_11x value), so this NDIS-era field is redundant. struct wlan_bssid_ex is an internal structure passed by pointer through the driver command queue; it is never serialized to firmware or onto the air (the wire data lives in ies[]), so dropping a member is layout-safe as long as the module is rebuilt as a whole. enum ndis_802_11_network_type existed only to type this field, so remove it as well. No functional change. Signed-off-by: Cong Nguyen <congnt264@gmail.com> Link: https://patch.msgid.link/20260603122806.1330145-1-congnt264@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07net: usb: lan78xx: disable VLAN filter in promiscuous modeEnrico Pozzobon
The hardware VLAN filter (RFE_CTL_VLAN_FILTER_) drops VLAN-tagged frames whose VID has not been registered via lan78xx_vlan_rx_add_vid(). It is left enabled in promiscuous mode, so packet capture (e.g. tcpdump or Wireshark) does not see tagged frames for unregistered VIDs. Clear the filter while the interface is promiscuous and restore it from NETIF_F_HW_VLAN_CTAG_FILTER otherwise. Enforce the same condition in lan78xx_set_features() so netdev_update_features() cannot re-enable the filter while promiscuous. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Enrico Pozzobon <enrico.pozzobon@dissecto.com> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de> Link: https://patch.msgid.link/20260701-lan78xx-vlan-promisc-v3-1-232266d32743@dissecto.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2026-07-07staging: rtl8723bs: remove unused 'oui' parameter from update_beacon()Nikolay Kulikov
After deleting one of the switch-case branches, this parameter became unused, so remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260601150253.69930-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused case from update_beacon()Nikolay Kulikov
The update_beacon() function is never called with 'ie_id' equal to 'WLAN_EID_VENDOR_SPECIFIC', meaning this case branch will never be called, so remove it and several related functions. Removing this case branch also fixes a possible null pointer dereference in update_bcn_vendor_spec() if 'oui' is NULL, since its value is not checked in any way. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260601150253.69930-2-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix alignmentEugene Mavick
Fix alignment to improve code readability and clear checkpatch warning: CHECK: Alignment should match open parenthesis Signed-off-by: Eugene Mavick <mavick4022@gmail.com> Link: https://patch.msgid.link/20260601093757.612130-3-mavick4022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: use nl80211_iftype instead of custom NDIS enumCong Nguyen
The driver defined its own enum ndis_802_11_network_infrastructure to represent the operating mode (STA/AP/IBSS) and translated nl80211 iftypes into it in cfg80211_rtw_change_iface(). The kernel already provides enum nl80211_iftype for this purpose, so use it directly and drop the redundant translation layer. Map the removed values as follows: Ndis802_11IBSS -> NL80211_IFTYPE_ADHOC Ndis802_11Infrastructure -> NL80211_IFTYPE_STATION Ndis802_11APMode -> NL80211_IFTYPE_AP Ndis802_11AutoUnknown -> NL80211_IFTYPE_UNSPECIFIED Compile-tested only. Signed-off-by: Cong Nguyen <congnt264@gmail.com> Link: https://patch.msgid.link/20260707104836.3176765-1-congnt264@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07Merge tag 'sfc-net-pullrequest-20260630' of ↵Paolo Abeni
git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl Lucero Palau, Alejandro says: ==================== pull request: sfc 2026-07-01 here are the last CXL core changes for enabling CXL Type2 drivers to initialize a CXL-capable device plus the netdev sfc driver changes using this new CXL core Type2 support. Please pull or let me know of any problem! SFC changes for CXL type2 enabling * tag 'sfc-net-pullrequest-20260630' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl: sfc: support pio mapping based on cxl sfc: obtain and map cxl range using devm_cxl_probe_mem sfc: Initialize cxl dpa sfc: Map cxl regs sfc: add cxl support cxl: Support dpa without a mailbox cxl: Support Type2 cxl regs mapping ==================== Link: https://patch.msgid.link/20260701113805.14072-1-alejandro.lucero-palau@amd.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2026-07-07staging: rtl8723bs: Rename camelcase variable dot11AuthAlgrthmDalvin-Ehinoma Noah Aiguobas
Rename variable dot11AuthAlgrthm to dot11_auth_algrthm in struct security_priv to resolve checkpatch.pl CamelCase finding. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/ahwHbMecWpijQBv9@koolguy Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused field 'bAPKThermalMeterIgnore'Nikolay Kulikov
This field is set to 'true' once and is never used again. Remove it to eliminate dead code. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260531080015.74870-1-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix space before tab in rtl8723b_dm.cPraveen Jayaprakash Pattar
Remove tab characters that appeared after '/*' in two comment lines, which caused 'please, no space before tabs' warnings. Replace the space+tab combination with a single space after the comment opener. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260531045511.5774-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix indentation in odm_EdcaTurboCheck.cPraveen Jayaprakash Pattar
Fix incorrect indentation of an if statement inside an else block. The statement had a space before it instead of proper tab alignment, causing checkpatch.pl to report 'suspect code indent' and 'statements should start on a tabstop' warnings. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260531040420.5426-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix spelling mistake found by codespellTomasz Unger
Corrected typo in comment: - varable -> variable Found by codespell. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> Link: https://patch.msgid.link/20260528-fix-typo-rtw-mlme-v1-1-2172d3227b00@yahoo.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix spelling mistake in rtw_recv.cTomasz Unger
Fix typo 'temporily' -> 'temporarily' in comments. Found by codespell. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> Link: https://patch.msgid.link/20260527-staging-fix-1-v1-1-66ad880bcf76@yahoo.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix spelling mistakes found by codespellTomasz Unger
Corrected typos in comments: - contrl -> control - Redifine -> Redefine - pauload -> payload Found by codespell. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> Link: https://patch.msgid.link/20260526-fix-typos-hal-com-reg-v1-1-9deb54e6e2e8@yahoo.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix spelling mistake found by codespellTomasz Unger
Corrected typo: FASLE -> FALSE in comment Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> Link: https://patch.msgid.link/20260526-fix-typo-odm-dig-v1-1-4392b0c03e13@yahoo.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove empty loop and stale comment in HalPhyRf.cIgor Putko
The 'for' loop in ODM_TXPowerTrackingCallback_ThermalMeter performs no operations and just iterates over the path count. This is unnecessary code. Also, remove the associated "Print Swing base & current" comment, as it no longer refers to any active code. Signed-off-by: Igor Putko <igorpetindev@gmail.com> Link: https://patch.msgid.link/20260525121004.4989-1-igorpetindev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: rename camelcase variable nSubframe_LengthAnirban Bose
Rename the variable 'nSubframe_Length' to 'subframe_len' in amsdu_to_msdu() and rtw_alloc_msdu_pkt() to resolve a checkpatch.pl CamelCase warning. Signed-off-by: Anirban Bose <boses156@gmail.com> Link: https://patch.msgid.link/20260525074419.144884-1-boses156@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix block comment style in HalPwrSeqCmd.cPraveen Jayaprakash Pattar
Fix non-standard block comment format. The comment was using '/*++' and '--*/' delimiters instead of the standard '/*' and '*/' used in kernel coding style. Also fix missing '*' prefix on subsequent lines and remove space before tab characters. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260524152506.5670-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.cAtharv Margur
Remove unnecessary braces around a single statement block to improve readability and conform to kernel coding style. No functional changes intended. Signed-off-by: Atharv Margur <atharvmargur@gmail.com> Link: https://patch.msgid.link/20260524111736.14477-1-atharvmargur@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix unnamed parameters warning detected at checkpatchRodrigo Gobbi
Detected the following WARNING: function definition argument 'struct adapter *' should also have an identifier name. Add explicit names on those definitions. Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com> Link: https://patch.msgid.link/20260609221200.123422-1-rodrigo.gobbi.7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix inconsistent braces in hal/sdio_halinit.cArtur Ugnivenko
Fix checkpatch warnings on inconsistent braces around if/else statements in hal/sdio_halinit.c Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260528170645.30861-3-artur.ugnivenko@gmx.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: shorten long lines in hal/sdio_halinit.cArtur Ugnivenko
Fix checkpatch warnings on lines above 100 chars in length by splitting long function calls and long comments into multiple lines. Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260528170645.30861-2-artur.ugnivenko@gmx.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix mismatched free of HalData in rtw_sdio_if1_init()Dawei Feng
padapter->HalData is allocated via vzalloc(), but incorrectly freed using kfree() in the rtw_sdio_if1_init() error path. Using kfree() to release this vmalloc-backed buffer can lead to memory corruption. Use rtw_hal_data_deinit() to pair the free correctly and free HalData with vfree(). The bug was first flagged by an experimental static analysis tool we are developing for kernel memory-management bugs. Manual inspection confirms that the issue is still present in current mainline. An x86_64 allyesconfig build showed no new warnings. As we do not have suitable RTL8723BS SDIO hardware to test with, no runtime testing was able to be performed. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Zilin Guan <zilin@seu.edu.cn> Signed-off-by: Dawei Feng <dawei.feng@seu.edu.cn> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260525091836.812565-1-dawei.feng@seu.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: rename CamelCase variable RxMgmtFrameSeqNumGianmaria Biselli
Rename RxMgmtFrameSeqNum to rx_mgmt_frame_seq_num to comply with kernel coding style. Found by checkpatch.pl strict. Signed-off-by: Gianmaria Biselli <gianmariabiselli@gmail.com> Link: https://patch.msgid.link/20260524031212.26208-1-gianmariabiselli@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: add missing spaces around '*' operatorMohammed Momin
Adhere to the Linux kernel coding style by adding missing spaces around the '*' binary operator in the init_channel_set function. This resolves a checkpatch warning and improves code readability. Signed-off-by: Mohammed Momin <linuxmomin0@gmail.com> Link: https://patch.msgid.link/20260523171903.30484-1-linuxmomin0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Fix line over 100 chars in xmit_linux.cPramod Maurya
Wrap the long function signature of rtw_os_xmit_resource_free to comply with the 100 column line length limit reported by checkpatch.pl. Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com> Link: https://patch.msgid.link/20260523162831.163704-1-pramod.nexgen@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unnecessary braces in rtl8723b_hal_init.cAtharv Margur
Remove unnecessary braces around single statement blocks to improve readability and conform to kernel coding style. No functional changes intended. Signed-off-by: Atharv Margur <atharvmargur@gmail.com> Link: https://patch.msgid.link/20260523141341.21607-1-atharvmargur@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: clean up wlanevents table in rtw_mlme_ext.cAndrei Khomenkov
Clean up the wlanevents table by removing redundant ampersands, adding all index comments and aligning them. Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org> Link: https://patch.msgid.link/20260522190256.49830-3-khomenkov@mailbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove dead rtw_atimdone_event_callback()Andrei Khomenkov
Remove the dead rtw_atimdone_event_callback() function since it is unused anywhere in the driver. In the wlanevents table, replace it with rtw_dummy_event_callback() to avoid an index shift. Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260522190256.49830-2-khomenkov@mailbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signatureMoksh Panicker
Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl. Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com> Link: https://patch.msgid.link/20260522125022.29700-3-mokshpanicker.7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.1) at 2026-08-11 15:35:18 +0000