From 5e63ade190446c6d0ce60830ecf0553c7a1761b0 Mon Sep 17 00:00:00 2001 From: Asbjørn Sloth Tønnesen Date: Mon, 31 Aug 2026 09:34:53 +0000 Subject: netlink: specs: rt-link: update ipv6 devconf doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit devconf is even odder than described in commit 720447bd0b24 ("netlink: specs: rt-link: remove implicit structs from devconf"), where both IPv4 and IPv6 are described in an identical way: "u32 indexed by ipv?-devconf - 1 on output, on input it's a nest". There are two issues with that line for IPv6: 1) The subtraction is an IPv4 specific quirk, to avoid having an unused u32 at index 0, thus saving 4 bytes per net device being dumped: - In include/uapi/linux/ip.h the IPV4_DEVCONF_* enum begins with IPV4_DEVCONF_FORWARDING = 1, so the enum starts at 1, which is the reason for the subtraction in the IPv4 variant. - In include/uapi/linux/ipv6.h the DEVCONF_* enum begins with DEVCONF_FORWARDING = 0, so subtraction would underflow. - ipv6_store_devconf() in net/ipv6/addrconf.c also doesn't do the subtraction in the output path. 2) Setting IPv6 devconf through Netlink is not yet supported, as IFLA_INET6_CONF is not handled in inet6_set_link_af(). Reviewed-by: Fernando Fernandez Mancera Signed-off-by: Asbjørn Sloth Tønnesen Link: https://patch.msgid.link/20260831093458.472180-2-ast@fiberby.net Signed-off-by: Paolo Abeni --- Documentation/netlink/specs/rt-link.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml index b80c2ac3ac31..00c915031efd 100644 --- a/Documentation/netlink/specs/rt-link.yaml +++ b/Documentation/netlink/specs/rt-link.yaml @@ -2218,7 +2218,7 @@ attribute-sets: name: conf type: binary sub-type: u32 - doc: u32 indexed by ipv6-devconf - 1 on output, on input it's a nest + doc: u32 indexed by ipv6-devconf on output, input is not yet implemented - name: stats type: binary -- cgit v1.2.3 From 2b0aecb7b2b1d8333a122d135c948f714cbc0fac Mon Sep 17 00:00:00 2001 From: Asbjørn Sloth Tønnesen Date: Mon, 31 Aug 2026 09:34:54 +0000 Subject: netlink: specs: rt-link: add accept-ra-min-lft MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add missing enum member accept-ra-min-lft to ipv6-devconf. In commit 1671bcfd76fd ("net: add sysctl accept_ra_min_rtr_lft") the DEVCONF_* enum was extended with DEVCONF_ACCEPT_RA_MIN_RTR_LFT. It was renamed to DEVCONF_ACCEPT_RA_MIN_LFT in commit 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes"). Shortly thereafter, this spec was introduced in commit b2f63d904e72 ("doc/netlink: Add spec for rt link messages"). This pre-existing issue was detected by Sashiko, when reviewing the first patch in this series. Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Fernando Fernandez Mancera Link: https://patch.msgid.link/20260831093458.472180-3-ast@fiberby.net Signed-off-by: Paolo Abeni --- Documentation/netlink/specs/rt-link.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml index 00c915031efd..ab677801cde8 100644 --- a/Documentation/netlink/specs/rt-link.yaml +++ b/Documentation/netlink/specs/rt-link.yaml @@ -494,6 +494,8 @@ definitions: name: ndisc-evict-nocarrier - name: accept-untracked-na + - + name: accept-ra-min-lft - name: ifla-icmp6-stats enum-name: -- cgit v1.2.3 From f952040d7016d13a0b0f19dfa0001f4597cc47d1 Mon Sep 17 00:00:00 2001 From: Asbjørn Sloth Tønnesen Date: Mon, 31 Aug 2026 09:34:55 +0000 Subject: netlink: specs: rt-link: add force-forwarding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add missing enum member force-forwarding to ipv6-devconf. In commit f24987ef6959 ("ipv6: add `force_forwarding` sysctl to enable per-interface forwarding"), the DEVCONF_* enum was extended with DEVCONF_FORCE_FORWARDING, however Gabriel forgot to add it to the spec. This pre-existing issue was detected by Sashiko, when reviewing the first patch in this series. Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Fernando Fernandez Mancera Reviewed-by: Gabriel Goller Link: https://patch.msgid.link/20260831093458.472180-4-ast@fiberby.net Signed-off-by: Paolo Abeni --- Documentation/netlink/specs/rt-link.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml index ab677801cde8..61ebb9a2bad5 100644 --- a/Documentation/netlink/specs/rt-link.yaml +++ b/Documentation/netlink/specs/rt-link.yaml @@ -496,6 +496,8 @@ definitions: name: accept-untracked-na - name: accept-ra-min-lft + - + name: force-forwarding - name: ifla-icmp6-stats enum-name: -- cgit v1.2.3