kernel/git/stable/linux-stable.git/drivers/accessibility, branch master

accessibility: speakup: unregister tty ldisc on later init failures

2026-07-17T12:54:56+00:00

The ldisc registration is intentionally non-fatal, since some synth drivers do not use tty/ldisc. However, once speakup_init() continues past the registration point and later fails, the init unwind path should mirror speakup_exit() and call spk_ttyio_unregister_ldisc(). Add the missing unregister call to the error path after synth_release(), matching the normal module exit cleanup order. Signed-off-by: Haoxiang Li Signed-off-by: Samuel Thibault Fixes: e23a9b439ce9 ("staging: speakup: safely register and unregister ldisc") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260531230804.254962-16-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: speakup_soft: fix comment style and repeated word

2026-07-17T12:54:56+00:00

Fix comment style issues in speakup_soft.c: - Move the closing '*/' of the block comment to its own line, as required by the kernel coding style Signed-off-by: Francisco Maestre Signed-off-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-15-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: Fix typo in a speakup message

2026-07-17T12:54:56+00:00

s/read windo/read window/ Signed-off-by: Colin Ian King Signed-off-by: Bastien Nocera Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-14-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: Fix incorrect "index" plural

2026-07-17T12:54:56+00:00

It's indexes or indices. Given that the constant is called "STAT_index_valid", "indexes" was the preferred plural. Signed-off-by: Bastien Nocera Signed-off-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-13-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: Fix spelling of "re-enable"

2026-07-17T12:54:55+00:00

Detected using codespell. Signed-off-by: Bastien Nocera Signed-off-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-12-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

Accessibility: speakup_soft: Fix double word in comments

2026-07-17T12:54:55+00:00

Remove the repeated word "the" in comments. Signed-off-by: Bo Liu Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-11-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: keyhelp: guard letter_offsets possible out-of-range indexing

2026-07-17T12:54:55+00:00

help_init() builds letter_offsets[] by using the first byte of each function name as an index via `(start & 31) - 1`. If function_names are overridden from sysfs (root) with a name starting outside [a–z], the index underflows or exceeds the array, leading to OOB write. Function names can be overridden with the following commands as root: modprobe speakup_soft echo "0 _bad" > /sys/accessibility/speakup/i18n/function_names # then press Insert+2 on /dev/tty This fix checks the first letter in help_init(), and if it is not in the [a–z] range the function returns an error to the caller. Eventually this error is propagated to drivers/accessibility/speakup/main.c:2217, which causes a bleep sound. Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory") Signed-off-by: Pavel Zhigulin Signed-off-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-10-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

accessibility: Use str_plural() to simplify the code

2026-07-17T12:54:55+00:00

Use the string choice helper function str_plural() to simplify the code. Signed-off-by: Xichao Zhao Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-9-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: Standardize character attribute types to u16

2026-07-17T12:54:55+00:00

This change replaces non-portable `u_short` types with standardized `u16` throughout the speakup subsystem to ensure: 1. Consistent 16-bit width across all architectures. 2. Improved code portability and readability. 3. Elimination of platform-dependent type sizes. 4. Safe bitwise operations without sign-extension risks. Signed-off-by: Jagadeesh Yalapalli Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-8-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman

speakup: Fix the wrong format specifier

2026-07-17T12:54:55+00:00

Make a minor change to eliminate a static checker warning. The type of '(unsigned int)kp[i]' is unsigned int, so the correct format specifier should be %u instead of %d. Signed-off-by: liujing Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Link: https://patch.msgid.link/20260531230804.254962-7-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman