kernel/git/stable/linux-stable.git/drivers/ide/ide-atapi.c, branch linux-2.6.29.yLinux kernel stable treehttps://git.rulkc.org/pub/scm/linux/kernel/git/stable/linux-stable.git/atom?h=linux-2.6.29.y2009-04-27T17:36:54+00:00ide-atapi: start DMA after issuing a packet command2009-04-27T17:36:54+00:00Borislav Petkovpetkovbb@gmail.com2009-04-02T20:21:31+00:00urn:sha1:717ff472176c54e90a4074898a59037f9a4791f5
upstream commit: 2eba08270990b99fb5429b76ee97184ddd272f7f
Apparently¹, some ATAPI devices want to see the packet command first
before enabling DMA otherwise they simply hang indefinitely. Reorder the
two steps and start DMA only after having issued the command first.
[1] http://marc.info/?l=linux-kernel&m=123835520317235&w=2
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Reported-by: Michael Roth <mroth@nessie.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
ide: drivers/ide/ide-atapi.c needs <linux/scatterlist.h>2009-04-27T17:36:54+00:00Geert Uytterhoevengeert@linux-m68k.org2009-04-02T20:20:22+00:00urn:sha1:d7715a3e33ca1f6698ac9bec7d767a55f07fd65a
upstream commit: 479edf065576aeed7ac99d10838bb3b4f870b5f9
On m68k:
| drivers/ide/ide-atapi.c: In function 'ide_io_buffers':
| drivers/ide/ide-atapi.c:87: error: implicit declaration of function 'sg_page'
| drivers/ide/ide-atapi.c:87: warning: passing argument 1 of 'PageHighMem' makes pointer from integer without a cast
| drivers/ide/ide-atapi.c:91: warning: passing argument 1 of 'kmap_atomic' makes pointer from integer without a cast
| drivers/ide/ide-atapi.c:96: error: implicit declaration of function 'sg_virt'
| drivers/ide/ide-atapi.c:96: warning: assignment makes pointer from integer without a cast
| drivers/ide/ide-atapi.c:107: error: implicit declaration of function 'sg_next'
| drivers/ide/ide-atapi.c:107: warning: assignment makes pointer from integer without a cast
[bart: Dmitri Vorobiev submitted similar patch fixing MIPS]
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
ide-floppy: do not map dataless cmds to an sg2009-03-13T20:16:12+00:00Borislav Petkovpetkovbb@gmail.com2009-03-13T20:16:12+00:00urn:sha1:3eb76c1ccde496c3c0bfda23d1c803e40b762ce6
since it fails the virt_to_page() translation check with DEBUG_VIRTUAL
enabled.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
[bart: backport to Linus' tree]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-cd: convert to ide-atapi facilities2009-01-06T16:20:58+00:00Borislav Petkovpetkovbb@gmail.com2009-01-06T16:20:58+00:00urn:sha1:d6251d4488a361c93da2398818e1ec69cffb6073
... and remove no longer needed cdrom_start_packet_command and
cdrom_transfer_packet_command.
Tested lightly with ide-cd and ide-floppy.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide: merge ide_hwgroup_t with ide_hwif_t (v2)2009-01-06T16:20:50+00:00Bartlomiej Zolnierkiewiczbzolnier@gmail.com2009-01-06T16:20:50+00:00urn:sha1:b65fac32cfe3b2f98cd472fef400bd1c1340de23
* Merge ide_hwgroup_t with ide_hwif_t.
* Cleanup init_irq() accordingly, then remove no longer needed
ide_remove_port_from_hwgroup() and ide_ports[].
* Remove now unused HWGROUP() macro.
While at it:
* ide_dump_ata_error() fixups
v2:
* Fix ->quirk_list check in do_ide_request()
(s/hwif->cur_dev/prev_port->cur_dev).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-atapi: start dma in a drive-specific way2009-01-02T15:12:56+00:00Borislav Petkovpetkovbb@googlemail.com2009-01-02T15:12:56+00:00urn:sha1:b16aabc9374217fa2d28e72fd9a6e6d60905e1b9
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-atapi: put the rest of non-ide-cd code into the else-clause of ide_transfer_pc2009-01-02T15:12:56+00:00Borislav Petkovpetkovbb@googlemail.com2009-01-02T15:12:56+00:00urn:sha1:06cc2778a1744b79edcfa394ce2d41f09134b2b1
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-atapi: remove timeout arg to ide_issue_pc2009-01-02T15:12:56+00:00Borislav Petkovpetkovbb@googlemail.com2009-01-02T15:12:56+00:00urn:sha1:28ad91db77755f1c49d79652de11b28ee2cfbf03
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-atapi: split drive-specific functionality in ide_issue_pc2009-01-02T15:12:55+00:00Borislav Petkovpetkovbb@googlemail.com2009-01-02T15:12:55+00:00urn:sha1:d77612ab0ad7515623b084b952dfefd547073ada
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
ide-atapi: assign expiry and timeout based on device type2009-01-02T15:12:55+00:00Borislav Petkovpetkovbb@googlemail.com2009-01-02T15:12:55+00:00urn:sha1:def860d061d0fcab7fbbe193c0b8b8f0b9b4c828
There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>