kernel/git/stable/linux-stable.git/fs/dlm/lock.c, branch linux-3.16.y

dlm: memory leaks on error path in dlm_user_request()

2019-04-04T15:13:42+00:00

commit d47b41aceeadc6b58abc9c7c6485bef7cfb75636 upstream. According to comment in dlm_user_request() ua should be freed in dlm_free_lkb() after successful attach to lkb. However ua is attached to lkb not in set_lock_args() but later, inside request_lock(). Fixes 597d0cae0f99 ("[DLM] dlm: user locks") Signed-off-by: Vasily Averin Signed-off-by: David Teigland Signed-off-by: Ben Hutchings

dlm: lost put_lkb on error path in receive_convert() and receive_unlock()

2019-04-04T15:13:41+00:00

commit c0174726c3976e67da8649ac62cae43220ae173a upstream. Fixes 6d40c4a708e0 ("dlm: improve error and debug messages") Signed-off-by: Vasily Averin Signed-off-by: David Teigland Signed-off-by: Ben Hutchings

dlm: possible memory leak on error path in create_lkb()

2019-04-04T15:13:41+00:00

commit 23851e978f31eda8b2d01bd410d3026659ca06c7 upstream. Fixes 3d6aa675fff9 ("dlm: keep lkbs in idr") Signed-off-by: Vasily Averin Signed-off-by: David Teigland Signed-off-by: Ben Hutchings

dlm: use INFO for recovery messages

2014-02-14T17:54:44+00:00

The log messages relating to the progress of recovery are minimal and very often useful. Change these to the KERN_INFO level so they are always available. Signed-off-by: David Teigland

dlm: silence a harmless use after free warning

2014-02-12T21:44:03+00:00

We pass the freed "r" pointer back to the caller. It's harmless but it upsets the static checkers. Signed-off-by: Dan Carpenter Signed-off-by: David Teigland

dlm: Avoid LVB truncation

2013-06-26T16:38:02+00:00

For lockspaces with an LVB length above 64 bytes, avoid truncating the LVB while exchanging it with another node in the cluster. Signed-off-by: Bart Van Assche Signed-off-by: David Teigland

dlm: convert to idr_alloc()

2013-02-28T03:10:19+00:00

Convert to the much saner new idr interface. Error return values from recover_idr_add() mix -1 and -errno. The conversion doesn't change that but it looks iffy. Signed-off-by: Tejun Heo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

dlm: avoid scanning unchanged toss lists

2013-01-07T18:02:49+00:00

Keep track of whether a toss list contains any shrinkable rsbs. If not, dlm_scand can avoid scanning the list for rsbs to shrink. Unnecessary scanning can otherwise waste a lot of time because the toss lists can contain a large number of rsbs that are non-shrinkable (directory records). Signed-off-by: David Teigland

dlm: fix lvb invalidation conditions

2012-11-16T17:20:42+00:00

When a node is removed that held a PW/EX lock, the existing master node should invalidate the lvb on the resource due to the purged lock. Previously, the existing master node was invalidating the lvb if it found only NL/CR locks on the resource during recovery for the removed node. This could lead to cases where it invalidated the lvb and shouldn't have, or cases where it should have invalidated and didn't. When recovery selects a *new* master node for a resource, and that new master finds only NL/CR locks on the resource after lock recovery, it should invalidate the lvb. This case was handled correctly (but was incorrectly applied to the existing master case also.) When a process exits while holding a PW/EX lock, the lvb on the resource should be invalidated. This was not happening. The lvb contents and VALNOTVALID flag should be recovered before granting locks in recovery so that the recovered lvb state is provided in the callback. The lvb was being recovered after the lock was granted. Signed-off-by: David Teigland

dlm: fix missing dir remove

2012-07-16T19:24:43+00:00

I don't know exactly how, but in some cases, a dir record is not removed, or a new one is created when it shouldn't be. The result is that the dir node lookup returns a master node where the rsb does not exist. In this case, The master node will repeatedly return -EBADR for requests, and the lock requests will be stuck. Until all possible ways for this to happen can be eliminated, a simple and effective way to recover from this situation is for the supposed master node to send a standard remove message to the dir node when it receives a request for a resource it has no rsb for. Signed-off-by: David Teigland