diff options
| author | Thadeu Lima de Souza Cascardo <cascardo@igalia.com> | 2025-02-10 13:16:22 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-07-04 13:38:41 +0200 |
| commit | a1c41aebb184d9228a440dcb6761224e65b0e49a (patch) | |
| tree | 299a7b77fb8465f4f6da7ab477308d3e0a290082 | |
| parent | 73f4c5111c6f06fc9e6340c7768e161a5974af83 (diff) | |
| download | linux-stable-a1c41aebb184d9228a440dcb6761224e65b0e49a.tar.gz linux-stable-a1c41aebb184d9228a440dcb6761224e65b0e49a.zip | |
dlm: prevent NPD when writing a positive value to event_done
commit 8e2bad543eca5c25cd02cbc63d72557934d45f13 upstream.
do_uevent returns the value written to event_done. In case it is a
positive value, new_lockspace would undo all the work, and lockspace
would not be set. __dlm_new_lockspace, however, would treat that
positive value as a success due to commit 8511a2728ab8 ("dlm: fix use
count with multiple joins").
Down the line, device_create_lockspace would pass that NULL lockspace to
dlm_find_lockspace_local, leading to a NULL pointer dereference.
Treating such positive values as successes prevents the problem. Given
this has been broken for so long, this is unlikely to break userspace
expectations.
Fixes: 8511a2728ab8 ("dlm: fix use count with multiple joins")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Nazar Kalashnikov <nazarkalashnikov0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/dlm/lockspace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index db33e521556e..c8c0b5f971c3 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -639,7 +639,7 @@ static int new_lockspace(const char *name, const char *cluster, lockspace to start running (via sysfs) in dlm_ls_start(). */ error = do_uevent(ls, 1); - if (error) + if (error < 0) goto out_recoverd; wait_for_completion(&ls->ls_members_done); |