From 950c8f79547c9331f56dfb7fe06f70ee861e49bc Mon Sep 17 00:00:00 2001 From: Jori Koolstra Date: Tue, 30 Jun 2026 12:53:45 +0200 Subject: jffs2: drop redundant S_IFDIR from mkdir vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to ->mkdir(), so OR-ing S_IFDIR into the mode again in jffs2_mkdir() is redundant. Drop it. Assisted-by: LLM Signed-off-by: Jori Koolstra Link: https://patch.msgid.link/20260630105400.68459-17-jkoolstra@xs4all.nl Reviewed-by: NeilBrown Signed-off-by: Christian Brauner (Amutable) --- fs/jffs2/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index c4088c3b4ac0..2b86adcbd8f4 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c @@ -462,8 +462,6 @@ static struct dentry *jffs2_mkdir (struct mnt_idmap *idmap, struct inode *dir_i, uint32_t alloclen; int ret; - mode |= S_IFDIR; - ri = jffs2_alloc_raw_inode(); if (!ri) return ERR_PTR(-ENOMEM); -- cgit v1.2.3