kernel/git/stable/linux.git/drivers/auxdisplay, branch linux-5.11.y

auxdisplay: Fix duplicate CHARLCD config symbol

2021-03-04T11:14:45+00:00

[ Upstream commit b45616445a6e346daf8a173a0c51413aec067ebb ] A second CHARLCD config symbol was added instead of moving the existing one. Fix this by removing the old one. Fixes: 718e05ed92ecac0d ("auxdisplay: Introduce hd44780_common.[ch]") Signed-off-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda Signed-off-by: Sasha Levin

auxdisplay: ht16k33: Fix refresh rate handling

2021-03-04T11:14:44+00:00

[ Upstream commit e89b0a426721a8ca5971bc8d70aa5ea35c020f90 ] Drop the call to msecs_to_jiffies(), as "HZ / fbdev->refresh_rate" is already the number of jiffies to wait. Fixes: 8992da44c6805d53 ("auxdisplay: ht16k33: Driver for LED controller") Signed-off-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda Signed-off-by: Sasha Levin

auxdisplay: panel: Remove redundant charlcd_ops structures

2020-11-16T16:13:37+00:00

The three struct charlcd_ops contain the same data, so we only need one of this structures. The other two are removed. Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda

auxdisplay: panel: Fix missing print function pointer

2020-11-16T16:13:04+00:00

charlcd drivers need to provide some print function to charlcd. For hd44780 based panel driver this function was missing. We provide the generic hd44780_common_print function which should be suitable. Fixes: b26deabb1d915fe87d395081bbd3058b938dee89 ("auxdisplay: hd44780_common_print") Reported-by: kernel test robot Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda

auxdisplay: fix platform_no_drv_owner.cocci warnings

2020-11-14T08:52:35+00:00

drivers/auxdisplay/lcd2s.c:373:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") CC: Lars Poeschel Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Miguel Ojeda

auxdisplay: fix use after free in lcd2s_i2c_remove()

2020-11-09T13:07:25+00:00

The kfree() needs to be moved down a line to prevent a use after free. Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") Signed-off-by: Dan Carpenter Signed-off-by: Miguel Ojeda

auxdisplay: hd44780_common: Fix build error

2020-11-09T13:06:27+00:00

When building the hd44780_common driver without a driver that actually uses it like panel or hd44780 you get a build error, because hd44780_common uses charlcd, but did not select it. Its users did select it. This is fixed now. hd4478_common now selects charlcd in Kconfig and panel and hd44780 do not. They only select hd44780_common. Reported-by: Randy Dunlap Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda

auxdisplay: add a driver for lcd2s character display

2020-11-04T10:04:05+00:00

This driver allows to use a lcd2s 20x4 character display from Modtronix engineering as an auxdisplay charlcd device. Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Do not print chars at end of line

2020-11-04T10:04:05+00:00

Skip printing characters at the end of a display line. This fits to the behaviour we already had, that the cursor is nailed to the last position of a line. This might slightly change behaviour. On hd44780 displays with one or two lines the previous implementation did still write characters to the buffer of the display even if they are currently not visible. The shift_display command could be used to set the "viewing window" to a new position in the buffer and then you could see the characters previously written. This described behaviour does not work for hd44780 displays with more than two display lines. There simply is not enough buffer. So the behaviour was a bit inconsistent across different displays. The new behaviour is to stop writing characters at the end of a visible line, even if there would be room in the buffer. This allows us to have an easy implementation, that should behave equal on all supported displays. This is not hd44780 hardware dependent anymore. Reviewed-by: Willy Tarreau Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda

auxdisplay: Change gotoxy calling interface

2020-11-04T10:04:04+00:00

Change the calling interface for gotoxy from supplying the x and y coordinates in the charlcd struct to explicitly supplying x and y in the function arguments. This is more intuitive and allows for moving the cursor to positions independent from the position saved in the charlcd struct. Reviewed-by: Willy Tarreau Signed-off-by: Lars Poeschel Signed-off-by: Miguel Ojeda