kernel/git/stable/linux.git/drivers/crypto/aspeed, branch master

crypto: aspeed - Remove redundant dev_err()

2026-07-27T00:29:27+00:00

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Andrew Jeffery Signed-off-by: Herbert Xu

crypto: aspeed - Propagate platform_get_irq() errors

2026-07-17T08:09:22+00:00

platform_get_irq() returns a positive IRQ number on success and a negative error code on failure. aspeed_acry_probe() and aspeed_hace_probe() already detect negative returns, but both convert every failure to -ENXIO. Return the original error code so callers can handle errors such as -EPROBE_DEFER correctly. Fixes: 2f1cf4e50c95 ("crypto: aspeed - Add ACRY RSA driver") Fixes: 70513e1d6559 ("crypto: aspeed - Fix check for platform_get_irq() errors") Signed-off-by: Narasimharao Vadlamudi Signed-off-by: Herbert Xu

crypto: aspeed - Use memcpy_from_sglist() in aspeed_ahash_dma_prepare()

2026-04-03T00:56:12+00:00

Replace scatterwalk_map_and_copy() with memcpy_from_sglist() in aspeed_ahash_dma_prepare(). The latter provides a simpler interface without requiring a direction parameter, making the code easier to read and less error-prone. No functional change intended. Signed-off-by: Paul Louvel Reviewed-by: Neal Liu Signed-off-by: Herbert Xu

crypto: aspeed - fix double free caused by devm

2025-10-23T04:53:23+00:00

The clock obtained via devm_clk_get_enabled() is automatically managed by devres and will be disabled and freed on driver detach. Manually calling clk_disable_unprepare() in error path and remove function causes double free. Remove the manual clock cleanup in both aspeed_acry_probe()'s error path and aspeed_acry_remove(). Fixes: 2f1cf4e50c95 ("crypto: aspeed - Add ACRY RSA driver") Signed-off-by: Haotian Zhang Signed-off-by: Herbert Xu

crypto: aspeed - Fix dma_unmap_sg() direction

2025-09-20T12:21:03+00:00

It seems like everywhere in this file, when the request is not bidirectionala, req->src is mapped with DMA_TO_DEVICE and req->dst is mapped with DMA_FROM_DEVICE. Fixes: 62f58b1637b7 ("crypto: aspeed - add HACE crypto driver") Cc: Signed-off-by: Thomas Fourier Signed-off-by: Herbert Xu

crypto: aspeed - Fix hash fallback path typo

2025-06-26T04:56:26+00:00

Fix typo in the fallback code path. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202506231830.us4hiwlZ-lkp@intel.com/ Signed-off-by: Herbert Xu

crypto: aspeed/hash - Fix potential overflow in dma_prepare_sg

2025-06-13T09:26:15+00:00

The mapped SG lists are written to hash_engine->ahash_src_addr which has the size ASPEED_HASH_SRC_DMA_BUF_LEN. Since scatterlists are not bound in size, make sure that size is not exceeded. If the mapped SG list is larger than the buffer, simply iterate over it as is done in the dma_prepare case. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Iterate on large hashes in dma_prepare

2025-06-13T09:26:15+00:00

Rather than failing a hash larger than ASPEED_CRYPTO_SRC_DMA_BUF_LEN, just hash them over and over again until it's done. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Add fallback

2025-06-13T09:26:15+00:00

If a hash request fails due to a DMA mapping error, or if it is too large to fit in the the driver buffer, use a fallback to do the hash rather than failing. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Use API partial block handling

2025-06-13T09:26:15+00:00

Use the Crypto API partial block handling. Also switch to the generic export format. Remove final function that is no longer used by the Crypto API. Move final padding into aspeed_ahash_dma_prepare_sg. Signed-off-by: Herbert Xu