kernel/git/stable/linux.git/drivers/crypto/ccree, branch linux-5.8.y

crypto: ccree - fix runtime PM imbalance on error

2020-10-29T09:07:18+00:00

[ Upstream commit b7b57a5643c2ae45afe6aa5e73363b553cacd14b ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. However, users of cc_pm_get(), a direct wrapper of pm_runtime_get_sync(), assume that PM usage counter will not change on error. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Fixes: 8c7849a30255c ("crypto: ccree - simplify Runtime PM handling") Signed-off-by: Dinghao Liu Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: ccree - fix resource leak on error path

2020-08-19T06:26:06+00:00

[ Upstream commit 9bc6165d608d676f05d8bf156a2c9923ee38d05b ] Fix a small resource leak on the error path of cipher processing. Signed-off-by: Gilad Ben-Yossef Fixes: 63ee04c8b491e ("crypto: ccree - add skcipher support") Cc: Markus Elfring Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: ccree - constify struct debugfs_reg32

2020-05-15T06:15:00+00:00

pid_cd_regs and debug_regs are never changed and can therefore be made const. This allows the compiler to put it in the text section instead of the data section. Before: text data bss dec hex filename 2871 2320 64 5255 1487 drivers/crypto/ccree/cc_debugfs.o After: text data bss dec hex filename 3255 1936 64 5255 1487 drivers/crypto/ccree/cc_debugfs.o Signed-off-by: Rikard Falkeborn Signed-off-by: Herbert Xu

crypto: ccree - use crypto_shash_tfm_digest()

2020-05-08T05:32:13+00:00

Instead of manually allocating a 'struct shash_desc' on the stack and calling crypto_shash_digest(), switch to using the new helper function crypto_shash_tfm_digest() which does this for us. Cc: Gilad Ben-Yossef Signed-off-by: Eric Biggers Acked-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - remove duplicated include from cc_aead.c

2020-03-30T00:50:48+00:00

Remove duplicated include. Signed-off-by: YueHaibing Signed-off-by: Herbert Xu

crypto: ccree - refactor AEAD IV in AAD handling

2020-03-12T12:00:16+00:00

Our handling of ciphers with IV trailing the AAD was correct but overly complicated. Refactor to simplify and possibly save one DMA burst. This has the added bonus of behaving the same as the generic rfc4543 implementation for none compliants inputs where the IV in the iv field was not the same as the IV in the AAD. There should be no change in behaviour with correct inputs. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - use crypto_ipsec_check_assoclen()

2020-03-12T12:00:16+00:00

Use crypto_ipsec_check_assoclen() instead of home grown functions. Clean up some unneeded code as a result. Delete stale comments while we're at it. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - only check condition if needed

2020-03-12T12:00:16+00:00

Move testing of condition to after the point we decide if we need it or not. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - remove ancient TODO remarks

2020-03-12T12:00:16+00:00

Remove left over ancient and now misleading TODO remarks. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - remove pointless comment

2020-03-12T12:00:16+00:00

removed pointless comment Signed-off-by: Hadar Gat Signed-off-by: Herbert Xu