kernel/git/stable/linux.git/drivers/md/dm.c, branch linux-4.6.y

dm: fix dm_target_io leak if clone_bio() returns an error

2016-04-11T15:49:09+00:00

Commit c80914e81ec5b08 ("dm: return error if bio_integrity_clone() fails in clone_bio()") changed clone_bio() such that if it does return error then the alloc_tio() created resources (both the bio that was allocated to be a clone and the containing dm_target_io struct) will leak. Fix this by calling free_tio() in __clone_and_map_data_bio()'s clone_bio() error path. Fixes: c80914e81ec5b08 ("dm: return error if bio_integrity_clone() fails in clone_bio()") Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm: fix rq_end_stats() NULL pointer in dm_requeue_original_request()

2016-03-14T21:04:34+00:00

An "old" (.request_fn) DM 'struct request' stores a pointer to the associated 'struct dm_rq_target_io' in rq->special. dm_requeue_original_request(), previously named dm_requeue_unmapped_original_request(), called dm_unprep_request() to reset rq->special to NULL. But rq_end_stats() would go on to hit a NULL pointer deference because its call to tio_from_request() returned NULL. Fix this by calling rq_end_stats() _before_ dm_unprep_request() Signed-off-by: Bryn M. Reeves Signed-off-by: Mike Snitzer Fixes: e262f34741 ("dm stats: add support for request-based DM devices") Cc: stable@vger.kernel.org # 4.2+

dm: return error if bio_integrity_clone() fails in clone_bio()

2016-03-10T22:12:10+00:00

clone_bio() now checks if bio_integrity_clone() returned an error rather than just drop it on the floor. Signed-off-by: Mike Snitzer

dm: drop unnecessary assignment of md->queue

2016-03-10T22:12:07+00:00

md->queue and q are the same thing in dm_old_init_request_queue() and dm_mq_init_request_queue(). Also drop the temporary 'struct request_queue *q' in dm_old_init_request_queue(). Signed-off-by: Bob Liu Signed-off-by: Mike Snitzer

dm: reorder 'struct mapped_device' members to fix alignment and holes

2016-03-10T22:12:07+00:00

Saves 16 bytes by eliminating 4 4byte holes but more importantly: numerous members that crossed cachelines were fixed. Signed-off-by: Mike Snitzer

dm: remove dummy definition of 'struct dm_table'

2016-03-10T22:12:06+00:00

Change the map pointer in 'struct mapped_device' from 'struct dm_table __rcu *' to 'void __rcu *' to avoid the need for the dummy definition. Signed-off-by: Mike Snitzer

dm: add 'dm_numa_node' module parameter

2016-03-10T22:12:06+00:00

Allows user to control which NUMA node the memory for DM device structures (e.g. mapped_device, request_queue, gendisk, blk_mq_tag_set) is allocated from. Defaults to NUMA_NO_NODE (-1). Allowable range is from -1 until the last online NUMA node id. Signed-off-by: Mike Snitzer

dm: allow immutable request-based targets to use blk-mq pdu

2016-02-23T03:34:37+00:00

This will allow DM multipath to use a portion of the blk-mq pdu space for target data (e.g. struct dm_mpath_io). Signed-off-by: Mike Snitzer

dm: rename target's per_bio_data_size to per_io_data_size

2016-02-23T03:34:37+00:00

Request-based DM will also make use of per_bio_data_size. Signed-off-by: Mike Snitzer

dm: distinquish old .request_fn (dm-old) vs dm-mq request-based DM

2016-02-23T03:34:33+00:00

Rename various methods to have either a "dm_old" or "dm_mq" prefix. Improve code comments to assist with understanding the duality of code that handles both "dm_old" and "dm_mq" cases. It is no much easier to quickly look at the code and _know_ that a given method is either 1) "dm_old" only 2) "dm_mq" only 3) common to both. Signed-off-by: Mike Snitzer