kernel/git/stable/linux.git/drivers/media/rc, branch linux-4.0.y

rc: img-ir: fix error in parameters passed to irq_free()

2015-05-06T20:04:00+00:00

commit 80ccf4ad06dc9d2f06a8347b2d309cdc959f72b3 upstream. img_ir_remove() passes a pointer to the ISR function as the 2nd parameter to irq_free() instead of a pointer to the device data structure. This issue causes unloading img-ir module to fail with the below warning after building and loading img-ir as a module. WARNING: CPU: 2 PID: 155 at ../kernel/irq/manage.c:1278 __free_irq+0xb4/0x214() Trying to free already-free IRQ 58 Modules linked in: img_ir(-) CPU: 2 PID: 155 Comm: rmmod Not tainted 3.14.0 #55 ... Call Trace: ... [<8048d420>] __free_irq+0xb4/0x214 [<8048d6b4>] free_irq+0xac/0xf4 [] img_ir_remove+0x54/0xd4 [img_ir] [<8073ded0>] platform_drv_remove+0x30/0x54 ... Fixes: 160a8f8aec4d ("[media] rc: img-ir: add base driver") Signed-off-by: Sifan Naeem Acked-by: James Hogan Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman

[media] lirc_dev: avoid potential null-dereference

2015-02-03T19:33:42+00:00

We have to check pointer for NULL and then dereference it. Signed-off-by: Andy Shevchenko Signed-off-by: Mauro Carvalho Chehab

[media] rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i

2015-01-29T20:26:31+00:00

Add support for the larger fifo found on sun5i and sun6i, having a separate compatible for the ir found on sun5i & sun6i also is useful if we ever want to add ir transmit support, because the sun5i & sun6i version do not have transmit support. Note this commits also adds checking for the end-of-packet interrupt flag (which was already enabled), as the fifo-data-available interrupt flag only gets set when the trigger-level is exceeded. So far we've been getting away with not doing this because of the low trigger-level, but this is something which we should have done since day one. Signed-off-by: Hans de Goede Acked-by: Mauro Carvalho Chehab Acked-by: Maxime Ripard Signed-off-by: Mauro Carvalho Chehab

[media] rc: sunxi-cir: Add support for an optional reset controller

2015-01-29T20:26:08+00:00

On sun6i the cir block is attached to the reset controller, add support for de-asserting the reset if a reset controller is specified in dt. Signed-off-by: Hans de Goede Acked-by: Mauro Carvalho Chehab Acked-by: Maxime Ripard Signed-off-by: Mauro Carvalho Chehab

[media] rc-main: Re-apply filter for no-op protocol change

2014-12-23T18:21:45+00:00

Since commit da6e162d6a46 ("[media] rc-core: simplify sysfs code"), when the IR protocol is set using the sysfs interface to the same set of protocols that are already set, store_protocols() does not refresh the scancode filter with the new protocol, even if it has already called the change_protocol() callback successfully. This results in the filter being disabled in the hardware and not re-enabled until the filter is set again using sysfs. Fix in store_protocols() by still re-applying the filter whenever the change_protocol() driver callback succeeded. The problem can be reproduced with the img-ir driver by setting a filter, and then setting the protocol to the same protocol that is already set: $ echo nec > protocols $ echo 0xffff > filter_mask $ echo nec > protocols After this, messages which don't match the filter were still being received. Fixes: da6e162d6a46 ("[media] rc-core: simplify sysfs code") Reported-by: Sifan Naeem Signed-off-by: James Hogan Cc: David Härdeman Cc: # v3.17+ Signed-off-by: Mauro Carvalho Chehab

[media] rc: img-ir: add philips rc6 decoder module

2014-12-23T17:17:31+00:00

Add img-ir module for decoding Philips rc6 protocol. Signed-off-by: Sifan Naeem Signed-off-by: Mauro Carvalho Chehab

[media] rc: img-ir: add philips rc5 decoder module

2014-12-23T17:16:40+00:00

Add img-ir module for decoding Philips rc5 protocol. Signed-off-by: Sifan Naeem Signed-off-by: Mauro Carvalho Chehab

[media] rc: img-ir: biphase enabled with workaround

2014-12-23T17:15:26+00:00

Biphase decoding in the current img-ir has got a quirk, where multiple Interrupts are generated when an incomplete IR code is received by the decoder. Patch adds a work around for the quirk and enables biphase decoding. Signed-off-by: Sifan Naeem Acked-by: James Hogan Signed-off-by: Mauro Carvalho Chehab

[media] rc: img-ir: pass toggle bit to the rc driver

2014-12-23T17:12:57+00:00

Add toggle bit to struct img_ir_scancode_req so that protocols can provide it to img_ir_handle_data(), and pass that toggle bit up to rc_keydown instead of 0. This is needed for the upcoming rc-5 and rc-6 patches. Signed-off-by: Sifan Naeem Signed-off-by: Mauro Carvalho Chehab

[media] rc: img-ir: add scancode requests to a struct

2014-12-23T17:11:50+00:00

The information being requested of hardware decode callbacks through the img-ir-hw scancode API is mounting up, so combine it into a struct which can be passed in with a single pointer rather than multiple pointer arguments. This allows it to be extended more easily without touching all the hardware decode callbacks. Signed-off-by: Sifan Naeem Signed-off-by: Mauro Carvalho Chehab