kernel/git/stable/linux.git/drivers/regulator, branch linux-4.17.yLinux kernel stable treehttps://git.rulkc.org/pub/scm/linux/kernel/git/stable/linux.git/atom?h=linux-4.17.y2018-08-03T05:48:00+00:00regulator: Don't return or expect -errno from of_map_mode()2018-08-03T05:48:00+00:00Douglas Andersondianders@chromium.org2018-04-18T15:54:18+00:00urn:sha1:99cf307b59c8c9007e7c02a8cd2b2269a8e5ad6e
[ Upstream commit 02f3703934a42417021405ef336fe45add13c3d1 ]
In of_get_regulation_constraints() we were taking the result of
of_map_mode() (an unsigned int) and assigning it to an int. We were
then checking whether this value was -EINVAL. Some implementers of
of_map_mode() were returning -EINVAL (even though the return type of
their function needed to be unsigned int) because they needed to
signal an error back to of_get_regulation_constraints().
In general in the regulator framework the mode is always referred to
as an unsigned int. While we could fix this to be a signed int (the
highest value we store in there right now is 0x8), it's actually
pretty clean to just define the regulator mode 0x0 (the lack of any
bits set) as an invalid mode. Let's do that.
Fixes: 5e5e3a42c653 ("regulator: of: Add support for parsing initial and suspend modes")
Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
regulator: add dummy function of_find_regulator_by_node2018-08-03T05:47:55+00:00Changbin Duchangbin.du@intel.com2018-05-02T13:44:57+00:00urn:sha1:666778425ab1b0621af3bd8f684c8e2cdfbd18c7
[ Upstream commit 08813e0ec1cb48e53c86a24d88d26b26878e7b6e ]
If device tree is not enabled, of_find_regulator_by_node() should have
a dummy function since the function call is still there.
This is to fix build error after CONFIG_NO_AUTO_INLINE is introduced.
If this option is enabled, GCC will not auto-inline functions that are
not explicitly marked as inline.
In this case (no CONFIG_OF), the copmiler will report error in function
regulator_dev_lookup().
W/O NO_AUTO_INLINE, function of_get_regulator() is auto-inlined and then
the call to of_find_regulator_by_node() is optimized out since
of_get_regulator() always return NULL.
W/ NO_AUTO_INLINE, the return value of of_get_regulator() is a variable
so the call to of_find_regulator_by_node() cannot be optimized out. So
we need a stub of_find_regulator_by_node().
static struct regulator_dev *regulator_dev_lookup(struct device *dev,
const char *supply)
{
struct regulator_dev *r = NULL;
struct device_node *node;
struct regulator_map *map;
const char *devname = NULL;
regulator_supply_alias(&dev, &supply);
/* first do a dt based lookup */
if (dev && dev->of_node) {
node = of_get_regulator(dev, supply);
if (node) {
r = of_find_regulator_by_node(node);
if (r)
return r;
...
Signed-off-by: Changbin Du <changbin.du@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
regulator: pfuze100: add .is_enable() for pfuze100_swb_regulator_ops2018-08-03T05:47:49+00:00Anson HuangAnson.Huang@nxp.com2018-05-17T07:27:22+00:00urn:sha1:02e9f887677c1f4449ebb9c9dc24e09ae2811cb4
[ Upstream commit 0b01fd3d40fe6402e5fa3b491ef23109feb1aaa5 ]
If is_enabled() is not defined, regulator core will assume
this regulator is already enabled, then it can NOT be really
enabled after disabled.
Based on Li Jun's patch from the NXP kernel tree.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Merge remote-tracking branches 'regulator/topic/88pg86x', 'regulator/topic/dt', 'regulator/topic/formatting' and 'regulator/topic/gpio' into regulator-next2018-03-28T02:33:53+00:00Mark Brownbroonie@kernel.org2018-03-28T02:33:53+00:00urn:sha1:36fd679f45a25a7c634b3dbec35a2d7fdb832a65Merge remote-tracking branch 'regulator/topic/qcom_smd' into regulator-next2018-03-28T02:33:51+00:00Mark Brownbroonie@kernel.org2018-03-28T02:33:51+00:00urn:sha1:bca334e3eac026f143ddf36835d3af8ba3c9a4f1Merge remote-tracking branch 'regulator/topic/qcom' into regulator-next2018-03-28T02:33:49+00:00Mark Brownbroonie@kernel.org2018-03-28T02:33:49+00:00urn:sha1:9a13ce38ebdac3ff3c1c5135978ab7f2cde02632Merge remote-tracking branch 'regulator/topic/core' into regulator-next2018-03-28T02:33:48+00:00Mark Brownbroonie@kernel.org2018-03-28T02:33:48+00:00urn:sha1:9dc886a255f7b3ff5ffbf03321321bc6978f6895regulator: qcom: smd: Add pm8998 and pmi8998 regulators2018-03-28T02:10:22+00:00Bjorn Anderssonbjorn.andersson@linaro.org2018-03-27T15:53:01+00:00urn:sha1:3cdb741efa02c5053a738d5816b70de11c4d6364
Add the pm8998 and pmi8998 regulators as used in the MSM8998 platform.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: core: Add missing blank line between functions2018-03-22T07:23:35+00:00Mark Brownbroonie@kernel.org2018-03-22T07:23:35+00:00urn:sha1:d3e4eccbb8ddd2bcf906a9c2a43980b00a568eb4
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: qcom_smd: Drop regulator/{machine,of_regulator} includes2018-03-22T01:52:15+00:00Stephen Boydswboyd@chromium.org2018-03-21T18:48:11+00:00urn:sha1:6a2e3c3ea31bba91191c4c1a8a6afd7f08f9399e
These seem to be leftovers from previous developments of the driver but
they never got removed. Dropping them still allows the code to compile
so everything must be fine.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>