kernel/git/stable/linux.git/drivers/scsi/aacraid, branch linux-2.6.16.y

[SCSI] aacraid: fix security weakness

2008-01-06T02:19:00+00:00

Actually there are several but one is trivially fixed 1. FSACTL_GET_NEXT_ADAPTER_FIB ioctl does not lock dev->fib_list but needs to 2. Ditto for FSACTL_CLOSE_GET_ADAPTER_FIB 3. It is possible to construct an attack via the SRB ioctls where the user obtains assorted elevated privileges. Various approaches are possible, the trivial ones being things like writing to the raw media via scsi commands and the swap image of other executing programs with higher privileges. So the ioctls should be CAP_SYS_RAWIO - at least all the FIB manipulating ones. This is a bandaid fix for #3 but probably the ioctls should grow their own capable checks. The other two bugs need someone competent in that driver to fix them. Signed-off-by: Alan Cox Acked-by: Mark Salyzyn Signed-off-by: James Bottomley Signed-off-by: Adrian Bunk

aacraid: fix security hole (CVE-2007-4308)

2007-11-02T02:41:27+00:00

On the SCSI layer ioctl path there is no implicit permissions check for ioctls (and indeed other drivers implement unprivileged ioctls). aacraid however allows all sorts of very admin only things to be done so should check. Signed-off-by: Alan Cox Acked-by: Mark Salyzyn Signed-off-by: Adrian Bunk

Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6

2006-02-16T20:47:44+00:00

[PATCH] bogus asm/delay.h includes

2006-02-08T01:56:41+00:00

asm/delay.h is non-portable; linux/delay.h should be used in generic code. Signed-off-by: Al Viro

[SCSI] aacraid: use no_uld_attach flag

2006-02-04T22:16:14+00:00

Received From Mark Salyzyn. In order to support user tools accessing the array components (SMART, Mode Page information, Cache page adjustments, WWN determination, Firmware updates etc), we take advantage of the no_uld_attach flag and deprecate the code that filters Inquiries to block the requests to array components. The quirk prevents the sd layer from attaching to the components. We also took the opportunity to balance the queue depths based on the total adapter queue depth to the array devices to reduce the chances of starvation. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley

[SCSI] aacraid: Update global function names

2006-02-04T22:16:07+00:00

Received from Mark Salyzyn, Reduce the possibility of namespace collision. Prefix with aac_. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley

[SCSI] aacraid: reduce device probe warnings

2006-02-04T22:15:56+00:00

Received from Mark Salyzyn. This patch sets up some device quirks surrounding arrays to inform the scsi layer that various mode pages are not supported. This reduces the severity of the complaints that show up in the logs as the array devices are enumerated. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley

[SCSI] aacraid: README update

2006-01-12T17:55:16+00:00

Received From Mark Salyzyn. Move the README from the driver directory to the Documentation directory. Updated the documentation, added descriptions for cards that were missing. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley

[SCSI] aacraid: 17 element sg performance update

2006-01-12T17:55:01+00:00

Received From Mark Salyzyn. The Jaguar and Corsair class of adapters (2410, 2810, 2610, 21610, CERC) perform better (about 10% better read performance, write performance neutral) with current Firmware if the OS limits the number of scatter gather elements to 17 per request. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley

[SCSI] aacraid: better sysfs adapter information

2006-01-12T17:54:45+00:00

Received from Mark Salyzyn. Provide more accurate adapter information. Allows the Adapter Firmware to override the Adapter product information. Signed-off-by: Mark Haverkamp Signed-off-by: James Bottomley