kernel/git/stable/linux.git/fs/bcachefs/subvolume.c, branch master

Remove bcachefs core code

2025-09-29T20:43:52+00:00

bcachefs was marked 'externally maintained' in 6.17 but the code remained to make the transition smoother. It's now a DKMS module, making the in-kernel code stale, so remove it to avoid any version confusion. Link: https://lore.kernel.org/linux-bcachefs/yokpt2d2g2lluyomtqrdvmkl3amv3kgnipmenobkpgx537kay7@xgcgjviv3n7x/T/ Signed-off-by: Linus Torvalds

bcachefs: Fix subvol to missing root repair

2025-06-04T20:45:41+00:00

We had a bug where the root inode of a subvolume was erronously deleted: bch2_evict_inode() called bch2_inode_rm(), meaning the VFS inode's i_nlink was somehow set to 0 when it shouldn't have - the inode in the btree indicated it clearly was not unlinked. This has been addressed with additional safety checks in bch2_inode_rm() - pulling in the safety checks we already were doing when deleting unlinked inodes in recovery - but the really disastrous bug was in check_subvols(), which on finding a dangling subvol (subvol with a missing root inode) would delete the subvolume. I assume this bug dates from early check_directory_structure() code, which originally handled subvolumes and normal paths - the idea being that still live contents of the subvolume would get reattached somewhere. But that's incorrect, and disastrously so; deleting a subvolume triggers deleting the snapshot ID it points to, deleting the entire contents. The correct way to repair is to recreate the root inode if it's missing; then any contents will get reattached under that subvolume's lost+found. Signed-off-by: Kent Overstreet

bcachefs: Add flags to subvolume_to_text()

2025-06-04T20:45:41+00:00

Signed-off-by: Kent Overstreet

bcachefs: BCH_RECOVERY_PASS_NO_RATELIMIT

2025-06-02T16:16:36+00:00

Add a superblock flag to temporarily disable ratelimiting for a recovery pass. This will be used to make check_key_has_snapshot safer: we don't want to delete a key for a missing snapshot unless we know that the snapshots and subvolumes btrees are consistent, i.e. check_snapshots and check_subvols have run recently. Changing those btrees - creating/deleting a subvolume or snapshot - will set the "disable ratelimit" flag, i.e. ensuring that those passes run if check_key_has_snapshot discovers an error. We're only disabling ratelimiting in the snapshot/subvol delete paths, we're not so concerned about the create paths. Signed-off-by: Kent Overstreet

bcachefs: bch_err_throw()

2025-06-02T16:16:35+00:00

Add a tracepoint for any time we return an error and unwind. Signed-off-by: Kent Overstreet

bcachefs: Replace rcu_read_lock() with guards

2025-06-01T04:03:12+00:00

The new guard(), scoped_guard() allow for more natural code. Some of the uses with creative flow control have been left. Signed-off-by: Kent Overstreet

bcachefs: bch2_run_explicit_recovery_pass() cleanup

2025-05-22T00:15:04+00:00

Consolidate the run_explicit_recovery_pass() interfaces by adding a flags parameter; this will also let us add a RUN_RECOVERY_PASS_ratelimit flag. Signed-off-by: Kent Overstreet

bcachefs: snapshot delete progress indicator

2025-05-22T00:14:40+00:00

Signed-off-by: Kent Overstreet

bcachefs: Run most explicit recovery passes persistent

2025-05-22T00:14:37+00:00

If we detect an error that requires running a recovery pass, and we're not in recovery, we won't be able to fix it until the next mount - make sure we're noting in the superblock that it needs to run. Signed-off-by: Kent Overstreet

bcachefs: bch_fs.writes -> enumerated_refs

2025-05-22T00:14:27+00:00

Drop the single-purpose write ref code in bcachefs.h, and convert to enumarated refs. Signed-off-by: Kent Overstreet