kernel/git/stable/linux.git/net/batman-adv/vis.c, branch linux-3.5.y

batman-adv: use ETH_HLEN instead of sizeof(struct ethhdr)

2012-04-18T07:54:01+00:00

Instead of using sizeof(struct ethhdr) it is strongly recommended to use the kernel macro ETH_HLEN. This patch substitute each occurrence of the former expressione with the latter one. Signed-off-by: Antonio Quartulli

batman-adv: Update copyright years

2012-02-16T18:50:21+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: convert time_after instances to has_timed_out

2012-02-16T18:50:20+00:00

To increase readability the has_timed_out() functions has been introduced. This patch converts existing time_after() calls to use this wrapper function (if applicable). This patch also converts all timeouts to miliseconds to be consistent. Signed-off-by: Marek Lindner Signed-off-by: Simon Wunderlich

batman-adv: Explicitly mark the common header structure

2012-02-16T18:50:19+00:00

All batman-adv packets have a common 3 byte header. It can be used to share some code between different code paths, but it was never explicit stated that this header has to be always the same for all packets. Therefore, new code changes always have the problem that they may accidently introduce regressions by moving some elements around. A new structure is introduced that contains the common header and makes it easier visible that these 3 bytes have to be the same for all on-wire packets. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: create a common substructure for tt_global/local_entry

2011-11-20T12:08:35+00:00

Several functions in the translation table management code assume that the tt_global_entry and tt_local_entry structures have the same initial fields such as 'addr' and 'hash_entry'. To improve the code readability and to avoid mistakes in later changes, a common substructure that substitute the shared fields has been introduced (struct tt_common_entry). Thanks to this modification, it has also been possible to slightly reduce the code length by merging some functions like compare_ltt/gtt() and tt_local/global_hash_find() Signed-off-by: Antonio Quartulli Signed-off-by: Sven Eckelmann

batman-adv: fixed hash functions type to uint32_t instead of int

2011-11-20T12:08:33+00:00

There are two reasons for this fix: - the result of choose_orig() and vis_choose() is an index and therefore it can't be negative. Hence it is correct to make the return type unsigned too. - sizeof(int) may not be the same on ALL the architectures. Since we plan to use choose_orig() as DHT hash function, we need to guarantee that, given the same argument, the result is the same. Then it is correct to explicitly express the size of the return type (and the second argument). Since the expected length is currently 4, uint32_t is the most convenient choice. Signed-off-by: Antonio Quartulli Signed-off-by: Sven Eckelmann

batman-adv: Remove unnecessary OOM logging messages

2011-09-08T15:52:30+00:00

Removing unnecessary messages saves code and text. Site specific OOM messages are duplications of a generic MM out of memory message and aren't really useful, so just delete them. Signed-off-by: Joe Perches Signed-off-by: Marek Lindner

batman-adv: correct several typ0s in the comments

2011-08-22T13:16:19+00:00

Several typos have been corrected and some sentences have been rephrased Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: hash_add() has to discriminate on the return value

2011-08-22T13:16:19+00:00

hash_add() returns 0 on success while returns -1 either on error and on entry already present. The caller could use such information to select its behaviour. For this reason it is useful that hash_add() returns -1 in case on error and returns 1 in case of entry already present. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: protect the local and the global trans-tables with rcu

2011-06-20T09:37:30+00:00

The local and the global translation-tables are now lock free and rcu protected. Signed-off-by: Antonio Quartulli Acked-by: Simon Wunderlich Signed-off-by: Sven Eckelmann