kernel/git/stable/linux.git/net/batman-adv, branch linux-3.5.y

batman-adv: make batadv_test_bit() return 0 or 1 only

2012-10-12T20:47:01+00:00

[ Upstream commit dbd6b11e15a2f96030da17dbeda943a8a98ee990 ] On some architectures test_bit() can return other values than 0 or 1: With a generic x86 OpenWrt image in a kvm setup (batadv_)test_bit() frequently returns -1 for me, leading to batadv_iv_ogm_update_seqnos() wrongly signaling a protected seqno window. This patch tries to fix this issue by making batadv_test_bit() return 0 or 1 only. Signed-off-by: Linus Lüssing Acked-by: Sven Eckelmann Signed-off-by: Antonio Quartulli Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman

batman-adv: check incoming packet type for bla

2012-07-05T22:08:46+00:00

If the gateway functionality is used, some broadcast packets (DHCP requests) may be transmitted as unicast packets. As the bridge loop avoidance code now only considers the payload Ethernet destination, it may drop the DHCP request for clients which are claimed by other backbone gateways, because it falsely infers from the broadcast address that the right backbone gateway should havehandled the broadcast. Fix this by checking and delegating the batman-adv packet type used for transmission. Reported-by: Guido Iribarren Signed-off-by: Simon Wunderlich

batman-adv: fix race condition in TT full-table replacement

2012-06-23T15:21:35+00:00

bug introduced with cea194d90b11aff7fc289149e4c7f305fad3535a In the current TT code, when a TT_Response containing a full table is received from an originator, first the node purges all the clients for that originator in the global translation-table and then merges the newly received table. During the purging phase each client deletion is done by means of a call_rcu() invocation and at the end of this phase the global entry counter for that originator is set to 0. However the invoked rcu function decreases the global entry counter for that originator by one too and since the rcu invocation is likely to be postponed, the node will end up in first setting the counter to 0 and then decreasing it one by one for each deleted client. This bug leads to having a wrong global entry counter for the related node, say X. Then when the node with the broken counter will answer to a TT_REQUEST on behalf of node X, it will create faulty TT_RESPONSE that will generate an unrecoverable situation on the node that asked for the full table recover. The non-recoverability is given by the fact that the node with the broken counter will keep answering on behalf of X because its knowledge about X's state (ttvn + tt_crc) is correct. To solve this problem the counter is not explicitly set to 0 anymore and the counter decrement is performed right before the invocation of call_rcu(). Signed-off-by: Antonio Quartulli

batman-adv: only drop packets of known wifi clients

2012-06-23T15:21:11+00:00

bug introduced with 59b699cdee039d75915c354da06937102d1f9a84 If the source or destination mac address of an ethernet packet could not be found in the translation table the packet was dropped if AP isolation was turned on. This behavior would make it impossible to send broadcast packets over the mesh as the broadcast address will never enter the translation table. Signed-off-by: Marek Lindner Acked-by: Antonio Quartulli

batman-adv: fix skb->data assignment

2012-06-19T21:49:08+00:00

skb_linearize(skb) possibly rearranges the skb internal data and then changes the skb->data pointer value. For this reason any other pointer in the code that was assigned skb->data before invoking skb_linearise(skb) must be re-assigned. In the current tt_query message handling code this is not done and therefore, in case of skb linearization, the pointer used to handle the packet header ends up in pointing to free'd memory. This bug was introduced by a73105b8d4c765d9ebfb664d0a66802127d8e4c7 (batman-adv: improved client announcement mechanism) Signed-off-by: Antonio Quartulli Cc: Signed-off-by: David S. Miller

batman-adv: unset the TT_CLIENT_PENDING flag if the new local entry already exists

2012-05-14T07:05:08+00:00

When trying to add a new tt_local_entry, if such entry already exists, we have to ensure that the TT_CLIENT_PENDING flag is not set, otherwise the entry will be deleted soon. Reported-by: Simon Wunderlich Signed-off-by: Antonio Quartulli

batman-adv: Start new development cycle

2012-05-13T17:06:42+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli

batman-adv: use shorter pr_warn instead of pr_warning

2012-05-13T17:06:41+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Antonio Quartulli

batman-adv: refactor window_protected to avoid unnecessary return statement

2012-05-13T17:06:40+00:00

Reported-by: David Laight Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

batman-adv: prepare lq_update_lock to be shared among different protocols

2012-05-13T17:06:39+00:00

Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli