kernel/git/stable/linux.git/sound/mips/hal2.c, branch linux-4.14.y

ALSA: mips: constify snd_pcm_ops structures

2017-08-19T09:02:18+00:00

snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by work with const snd_pcm_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav Signed-off-by: Takashi Iwai

ALSA: mips: make snd_pcm_hardware const

2017-08-17T10:44:14+00:00

Make these const as they are only used in a copy operation. Done using Coccinelle Signed-off-by: Bhumika Goyal Signed-off-by: Takashi Iwai

ALSA: hal2: switch to dma_alloc_attrs

2017-06-16T09:10:05+00:00

Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig Signed-off-by: Takashi Iwai

ALSA: declare snd_kcontrol_new structures as const

2017-05-30T08:29:25+00:00

Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@ static struct snd_kcontrol_new x@p={...}; @ok@ identifier r.x; position p; @@ snd_ctl_new1(&x@p,...) @bad@ position p != {r.p,ok.p}; identifier r.x; @@ x@p @depends on !bad disable optional_qualifier@ identifier r.x; @@ +const struct snd_kcontrol_new x; Cross compiled these files: sound/aoa/codecs/tas.c - powerpc sound/mips/{hal2.c/sgio2audio.c} - mips sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc sound/soc/sh/siu_dai.c - sh Could not find an architecture to compile sound/sh/aica.c. Signed-off-by: Bhumika Goyal Acked-by: Mark Brown Signed-off-by: Takashi Iwai

ALSA: mips: Deliver indirect-PCM transfer error

2017-05-25T21:34:46+00:00

Now that the indirect-PCM transfer helper gives back an error, we should return the error from ack callbacks. Signed-off-by: Takashi Iwai

ALSA: mips: avoid potential uninitialized variable use

2017-01-16T13:33:42+00:00

MIPS allmodconfig results in this warning: sound/mips/hal2.c: In function 'hal2_gain_get': sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c:223:35: error: 'l' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c: In function 'hal2_gain_put': sound/mips/hal2.c:260:13: error: 'new' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c:260:13: error: 'old' may be used uninitialized in this function [-Werror=maybe-uninitialized] Returning an error for all unexpected cases shuts up the warning Signed-off-by: Arnd Bergmann Signed-off-by: Takashi Iwai

ALSA: mips: drop owner assignment from platform_drivers

2014-10-20T14:22:01+00:00

A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang

ALSA: mips: Convert to snd_card_new() with a device pointer

2014-02-14T07:14:05+00:00

Also remove superfluous snd_card_set_dev() calls. Signed-off-by: Takashi Iwai

ALSA: mips/hal2: Remove redundant platform_set_drvdata()

2013-05-06T08:45:47+00:00

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Thomas Bogendoerfer Signed-off-by: Takashi Iwai

ALSA: mips: remove __dev* attributes

2012-12-07T06:29:45+00:00

CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton Signed-off-by: Takashi Iwai