diff options
| author | Wentao Liang <vulab@iscas.ac.cn> | 2026-04-08 15:45:34 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-07-04 13:39:40 +0200 |
| commit | 866184fc7ae42a0070f1141ae8c5dca7c24a59e2 (patch) | |
| tree | 4d75093efc95ebb2224af973812d695b298e0bcb | |
| parent | c2c7733101bb8c0b29ac9ee41073eaf602821a59 (diff) | |
| download | linux-866184fc7ae42a0070f1141ae8c5dca7c24a59e2.tar.gz linux-866184fc7ae42a0070f1141ae8c5dca7c24a59e2.zip | |
fpga: region: fix use-after-free in child_regions_with_firmware()
commit 54f3c5643ec523a04b6ec0e7c19eb10f5ebebdd3 upstream.
Move of_node_put(child_region) after the error print to avoid accessing
freed memory when pr_err() references child_region.
Fixes: 0fa20cdfcc1f ("fpga: fpga-region: device tree control for FPGA")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
[ Yilun: Fix the Fixes tag ]
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20260408154534.404327-1-vulab@iscas.ac.cn
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/fpga/of-fpga-region.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 9c662db1c508..4fc8a7071ae1 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -166,11 +166,10 @@ static int child_regions_with_firmware(struct device_node *overlay) fpga_region_of_match); } - of_node_put(child_region); - if (ret) pr_err("firmware-name not allowed in child FPGA region: %pOF", child_region); + of_node_put(child_region); return ret; } |