diff options
| author | Yann Gautier <yann.gautier@st.com> | 2026-06-23 15:31:32 +0200 |
|---|---|---|
| committer | Yann Gautier <yann.gautier@st.com> | 2026-06-26 13:12:51 +0200 |
| commit | 05087afeda3d1273d494f20353cfa0f3398c61d4 (patch) | |
| tree | db696cf5f32aceed14aba17abda7d8be61cf3066 | |
| parent | 334c14ecad4d6aeb470ec52e6508e21807111a49 (diff) | |
| download | arm-trusted-firmware-05087afeda3d1273d494f20353cfa0f3398c61d4.tar.gz arm-trusted-firmware-05087afeda3d1273d494f20353cfa0f3398c61d4.zip | |
fix(smccc): initialize ret for SMC_PCI_READ
After implementing stub functions for PCI SVC on Arm platforms, there is
a build warning:
In function 'pci_smc_handler', inlined from 'std_svc_smc_handler'
at services/std_svc/std_svc_setup.c:227:10:
services/std_svc/pci_svc.c:82:25: error: 'ret' may be used uninitialized
[-Werror=maybe-uninitialized]
82 | SMC_RET2(handle, SMC_PCI_CALL_SUCCESS,
ret);
| ^
services/std_svc/pci_svc.c: In function 'std_svc_smc_handler':
services/std_svc/pci_svc.c:71:26: note: 'ret' was declared here
71 | uint32_t ret;
| ^
Initialize the ret variable to 0U.
Change-Id: I0e9d4a08c8b68d2afdb5ca9608aec591790dcc57
Signed-off-by: Yann Gautier <yann.gautier@st.com>
| -rw-r--r-- | services/std_svc/pci_svc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/std_svc/pci_svc.c b/services/std_svc/pci_svc.c index a02b8a745..5d7eac433 100644 --- a/services/std_svc/pci_svc.c +++ b/services/std_svc/pci_svc.c @@ -68,7 +68,7 @@ uint64_t pci_smc_handler(uint32_t smc_fid, } break; case SMC_PCI_READ: { - uint32_t ret; + uint32_t ret = 0U; if (validate_rw_addr_sz(x1, x2, x3) != SMC_PCI_CALL_SUCCESS) { SMC_RET2(handle, SMC_PCI_CALL_INVAL_PARAM, 0U); |