diff options
| author | Jamie Gibbons <jamie.gibbons@microchip.com> | 2026-05-18 15:17:11 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2026-06-08 15:38:25 -0600 |
| commit | 763435d0e3124539dc36c730c3832a1b4162d3f7 (patch) | |
| tree | 36b4efa1cfe2c88a43b519012cad340ae3d50483 /drivers | |
| parent | 1173e02c9880d9f7d1bf15308490493332b03a61 (diff) | |
| download | u-boot-763435d0e3124539dc36c730c3832a1b4162d3f7.tar.gz u-boot-763435d0e3124539dc36c730c3832a1b4162d3f7.zip | |
mailbox: mpfs-mbox: fix driver bug and cleanup
Remove an unused and invalid struct mbox_chan pointer from the private
data and fix incorrect memory handling in the probe path, where the
private data structure was allocated.
This change corrects a functional bugs and cleans up the driver without
altering its behavior.
Fixes: 111e9bf6a5ac ("mailbox: add PolarFire SoC mailbox driver")
Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mailbox/mpfs-mbox.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/mailbox/mpfs-mbox.c b/drivers/mailbox/mpfs-mbox.c index 2e20b08307c..08c51c96718 100644 --- a/drivers/mailbox/mpfs-mbox.c +++ b/drivers/mailbox/mpfs-mbox.c @@ -37,13 +37,12 @@ struct mpfs_mbox { struct udevice *dev; void __iomem *ctrl_base; void __iomem *mbox_base; - struct mbox_chan *chan; }; static bool mpfs_mbox_busy(struct mbox_chan *chan) { struct mpfs_mbox *mbox = dev_get_priv(chan->dev); - uint16_t status; + u32 status; status = readl(mbox->ctrl_base + SERVICES_SR_OFFSET); @@ -152,7 +151,6 @@ static int mpfs_mbox_probe(struct udevice *dev) mbox->mbox_base = devm_ioremap(dev, res.start, resource_size(&res)); mbox->dev = dev; - mbox->chan->con_priv = mbox; return 0; } |