diff options
| author | VarshitPandya <varshit.pandya@arm.com> | 2026-07-01 11:15:20 +0100 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2026-07-02 07:22:54 +0000 |
| commit | 7bc6629f400c03970614420366edddecbd0dabcb (patch) | |
| tree | b09c318a4afaf4cb57bd4ae3593f0d714889d8c0 | |
| parent | 8dab052c576da59759e1c7bda834a47ca281162f (diff) | |
| download | edk2-7bc6629f400c03970614420366edddecbd0dabcb.tar.gz edk2-7bc6629f400c03970614420366edddecbd0dabcb.zip | |
ShellPkg: Fix smbiosview Type 26 location/status decode
The smbiosview Type 26 Voltage Probe decoder uses the low 5 bits of
LocationAndStatus as the probe location and the high 3 bits as the probe
status.
However, the Type 26 lookup tables were swapped: VPLocationTable contained
status strings and VPStatusTable contained location strings. This caused
valid records to be displayed as, for example:
Voltage Probe - Location: OK
Voltage Probe - Status: Processor
Swap the table contents so Type 26 output matches the SMBIOS
LocationAndStatus bit layout.
Signed-off-by: VarshitPandya <varshit.pandya@arm.com>
| -rw-r--r-- | ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 54 |
1 files changed, 27 insertions, 27 deletions
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index 4dce68dccf..9d3219b6eb 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -3246,33 +3246,6 @@ TABLE_ITEM VPLocationTable[] = { },
{
0x03,
- L" OK "
- },
- {
- 0x04,
- L" Non-critical "
- },
- {
- 0x05,
- L" Critical "
- },
- {
- 0x06,
- L" Non-recoverable "
- },
-};
-
-TABLE_ITEM VPStatusTable[] = {
- {
- 0x01,
- L" Other "
- },
- {
- 0x02,
- L" Unknown "
- },
- {
- 0x03,
L" Processor "
},
{
@@ -3309,6 +3282,33 @@ TABLE_ITEM VPStatusTable[] = { },
};
+TABLE_ITEM VPStatusTable[] = {
+ {
+ 0x01,
+ L" Other "
+ },
+ {
+ 0x02,
+ L" Unknown "
+ },
+ {
+ 0x03,
+ L" OK "
+ },
+ {
+ 0x04,
+ L" Non-critical "
+ },
+ {
+ 0x05,
+ L" Critical "
+ },
+ {
+ 0x06,
+ L" Non-recoverable "
+ },
+};
+
TABLE_ITEM CoolingDeviceStatusTable[] = {
{
0x01,
|