diff options
| author | Guangshuo Li <lgs201920130244@gmail.com> | 2026-09-15 15:55:20 +0800 |
|---|---|---|
| committer | Sakari Ailus <sakari.ailus@linux.intel.com> | 2026-09-15 13:01:37 +0300 |
| commit | 069a0343581bfcaee44bc598e2b95be2e2789807 (patch) | |
| tree | 9148f2bd10e2f0164701ed66f110fc3e2fc54e14 | |
| parent | 0d2ca640318612402ae1c640d2da56b2914ff994 (diff) | |
| download | linux-next-069a0343581bfcaee44bc598e2b95be2e2789807.tar.gz linux-next-069a0343581bfcaee44bc598e2b95be2e2789807.zip | |
media: i2c: ar0521: remove duplicate media entity cleanup
The error path taken when ar0521_power_on() fails calls
media_entity_cleanup() at the disable label and then falls through to
the entity_cleanup label, where media_entity_cleanup() is called again.
There is no need to clean up the media entity twice. Remove the first
call and let all error paths converge on the common entity_cleanup
label.
This issue was found by manual code inspection.
Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
| -rw-r--r-- | drivers/media/i2c/ar0521.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index ed324c2d87aa..be68789eb8f5 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -1142,7 +1142,6 @@ static int ar0521_probe(struct i2c_client *client) disable: v4l2_async_unregister_subdev(&sensor->sd); - media_entity_cleanup(&sensor->sd.entity); free_ctrls: v4l2_ctrl_handler_free(&sensor->ctrls.handler); entity_cleanup: |