summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDimitri Daskalakis <daskald@meta.com>2026-09-11 15:42:55 -0700
committerJakub Kicinski <kuba@kernel.org>2026-09-15 16:11:36 -0700
commit3661253d2253b92d30e3734aa46e5ad41df7043d (patch)
tree6e3172cb9dd32ad605eb6c7fa4f6eb57d3127d59
parent47dbcfdf942a35dbf842ea05bb2248fcda411da7 (diff)
downloadlinux-next-3661253d2253b92d30e3734aa46e5ad41df7043d.tar.gz
linux-next-3661253d2253b92d30e3734aa46e5ad41df7043d.zip
selftests: drv-net: remove duplicate functions in hds.py
There were duplicate definitions of the enabled_set_xdp and set_xdp test methods. The two enabled_set_xdp copies were identical apart from a comment and whitespace. The set_xdp copies differed by a reset of the hds configuration. commit ee3ae27721fb ("selftests: drv-net: hds: restore hds settings") introduced the config reset, but this was shadowed by the copy. Signed-off-by: Dimitri Daskalakis <daskald@meta.com> Link: https://patch.msgid.link/20260911224255.3675903-1-dimitri.daskalakis1@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rwxr-xr-xtools/testing/selftests/drivers/net/hds.py29
1 files changed, 0 insertions, 29 deletions
diff --git a/tools/testing/selftests/drivers/net/hds.py b/tools/testing/selftests/drivers/net/hds.py
index c4fe049e9baa..606e26d75951 100755
--- a/tools/testing/selftests/drivers/net/hds.py
+++ b/tools/testing/selftests/drivers/net/hds.py
@@ -240,35 +240,6 @@ def enabled_set_xdp(cfg, netnl) -> None:
_xdp_onoff(cfg)
-def set_xdp(cfg, netnl) -> None:
- """
- Enable single-buffer XDP on the device.
- When HDS is in "auto" / UNKNOWN mode, XDP installation should work.
- """
- mode = _get_hds_mode(cfg, netnl)
- if mode == 'enabled':
- netnl.rings_set({'header': {'dev-index': cfg.ifindex},
- 'tcp-data-split': 'unknown'})
-
- _xdp_onoff(cfg)
-
-
-def enabled_set_xdp(cfg, netnl) -> None:
- """
- Enable single-buffer XDP on the device.
- When HDS is in "enabled" mode, XDP installation should not work.
- """
- _get_hds_mode(cfg, netnl) # Trigger skip if not supported
-
- netnl.rings_set({'header': {'dev-index': cfg.ifindex},
- 'tcp-data-split': 'enabled'})
- defer(netnl.rings_set, {'header': {'dev-index': cfg.ifindex},
- 'tcp-data-split': 'unknown'})
-
- with ksft_raises(CmdExitFailure) as e:
- _xdp_onoff(cfg)
-
-
def ioctl(cfg, netnl) -> None:
mode1 = _get_hds_mode(cfg, netnl)
_ioctl_ringparam_modify(cfg, netnl)