diff options
| author | Jiawen Liu <1298662399@qq.com> | 2026-06-18 20:45:17 +0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-06-30 12:34:26 +0100 |
| commit | 3b5414d76a0381db77b9694537254af7acfa187a (patch) | |
| tree | 9b088283a7898d671d5f2fd154d8d6df3c960bd1 | |
| parent | bbbc1ef5b35341c5122418a14f8924688a4bb954 (diff) | |
| download | linux-next-3b5414d76a0381db77b9694537254af7acfa187a.tar.gz linux-next-3b5414d76a0381db77b9694537254af7acfa187a.zip | |
spi: bcm63xx-hsspi: return error from failed controller suspend
spi_controller_suspend() can fail if the SPI core cannot stop the
controller. bcm63xx_hsspi_suspend() ignored that error, disabled the
PLL and core clocks, and returned success.
Return the suspend error before disabling the clocks.
Signed-off-by: Jiawen Liu <1298662399@qq.com>
Acked-by: William Zhang <william.zhang@broadcom.com>
Link: https://patch.msgid.link/tencent_B5A06807924A77C8690730EBF7A052AABE05@qq.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-bcm63xx-hsspi.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index 58012e1b5ae7..37b3534d0b0a 100644 --- a/drivers/spi/spi-bcm63xx-hsspi.c +++ b/drivers/spi/spi-bcm63xx-hsspi.c @@ -889,8 +889,12 @@ static int bcm63xx_hsspi_suspend(struct device *dev) { struct spi_controller *host = dev_get_drvdata(dev); struct bcm63xx_hsspi *bs = spi_controller_get_devdata(host); + int ret; + + ret = spi_controller_suspend(host); + if (ret) + return ret; - spi_controller_suspend(host); clk_disable_unprepare(bs->pll_clk); clk_disable_unprepare(bs->clk); |