diff options
| author | Hrushiraj Gandhi <hrushirajg23@gmail.com> | 2026-09-01 12:59:50 +0530 |
|---|---|---|
| committer | Conor Dooley <conor.dooley@microchip.com> | 2026-09-08 20:36:04 +0100 |
| commit | 525e00a1bbced112f5431448842b27fa7621725f (patch) | |
| tree | 6a271b55621ddb0111df40c691a2137570bc5623 | |
| parent | cee9395acd8043be0644b25c34bfa86623f2b935 (diff) | |
| download | linux-next-525e00a1bbced112f5431448842b27fa7621725f.tar.gz linux-next-525e00a1bbced112f5431448842b27fa7621725f.zip | |
firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply
response_msg is sized as
AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg) by hand in both
call sites. Use kzalloc_objs() instead, matching the kzalloc_obj()
already used elsewhere in this same file for the other allocations in
these functions, and getting the same overflow-checked size
computation kzalloc_obj() already benefits from.
No functional change.
Signed-off-by: Hrushiraj Gandhi <hrushirajg23@gmail.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
| -rw-r--r-- | drivers/firmware/microchip/mpfs-auto-update.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c index 1211fd8d0463..b97d34bd2354 100644 --- a/drivers/firmware/microchip/mpfs-auto-update.c +++ b/drivers/firmware/microchip/mpfs-auto-update.c @@ -156,7 +156,7 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader) { struct mpfs_auto_update_priv *priv = fw_uploader->dd_handle; u32 *response_msg __free(kfree) = - kzalloc(AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg), GFP_KERNEL); + kzalloc_objs(*response_msg, AUTO_UPDATE_FEATURE_RESP_SIZE); struct mpfs_mss_response *response __free(kfree) = kzalloc_obj(struct mpfs_mss_response); struct mpfs_mss_msg *message __free(kfree) = @@ -358,7 +358,7 @@ static const struct fw_upload_ops mpfs_auto_update_ops = { static int mpfs_auto_update_available(struct mpfs_auto_update_priv *priv) { u32 *response_msg __free(kfree) = - kzalloc(AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg), GFP_KERNEL); + kzalloc_objs(*response_msg, AUTO_UPDATE_FEATURE_RESP_SIZE); struct mpfs_mss_response *response __free(kfree) = kzalloc_obj(struct mpfs_mss_response); struct mpfs_mss_msg *message __free(kfree) = |