summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPo-Hao Huang <phhuang@realtek.com>2026-07-29 20:43:53 +0800
committerPing-Ke Shih <pkshih@realtek.com>2026-08-02 09:31:07 +0800
commit58c0d447c53b4e5a50fdeaa30aa207df1406951f (patch)
tree5842af37afdb1c2bb4104d35eb6213f4e589298e
parent304720870f4cf24042bcad3ed6d7144710926d72 (diff)
downloadlinux-next-58c0d447c53b4e5a50fdeaa30aa207df1406951f.tar.gz
linux-next-58c0d447c53b4e5a50fdeaa30aa207df1406951f.zip
wifi: rtw89: fix scan offload version check logic
The version check with less than should check for smallest upper-bound first, or some branch will be unreachable. Signed-off-by: Po-Hao Huang <phhuang@realtek.com> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Link: https://patch.msgid.link/20260729124354.3231368-3-pkshih@realtek.com
-rw-r--r--drivers/net/wireless/realtek/rtw89/fw.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 5ab80bda3ae5..a3d72fbaba54 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -7748,12 +7748,12 @@ int rtw89_fw_h2c_scan_offload_be(struct rtw89_dev *rtwdev,
rtw89_scan_get_6g_disabled_chan(rtwdev, option);
- if (RTW89_CHK_FW_FEATURE(SCAN_OFFLOAD_BE_V1, &rtwdev->fw)) {
- cfg_len = offsetofend(typeof(*h2c), w9);
- scan_offload_ver = 1;
- } else if (RTW89_CHK_FW_FEATURE(SCAN_OFFLOAD_BE_V0, &rtwdev->fw)) {
+ if (RTW89_CHK_FW_FEATURE(SCAN_OFFLOAD_BE_V0, &rtwdev->fw)) {
cfg_len = offsetofend(typeof(*h2c), w8);
scan_offload_ver = 0;
+ } else if (RTW89_CHK_FW_FEATURE(SCAN_OFFLOAD_BE_V1, &rtwdev->fw)) {
+ cfg_len = offsetofend(typeof(*h2c), w9);
+ scan_offload_ver = 1;
}
len = cfg_len + macc_role_size + opch_size;