summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikhil P. Rao <nikhil.rao@amd.com>2026-09-01 04:42:18 +0000
committerJakub Kicinski <kuba@kernel.org>2026-09-04 18:07:36 -0700
commit73608de7e59246b4b533c1ffaee158a7048e186e (patch)
tree24b96e6bcd5e8a8d03ea32831d99ce7e4ebbe5c6
parent7980325b2f71e3f65c1323c39792e2455da6fab6 (diff)
downloadlinux-next-73608de7e59246b4b533c1ffaee158a7048e186e.tar.gz
linux-next-73608de7e59246b4b533c1ffaee158a7048e186e.zip
pds_core: don't release PCI regions for VFs on reset
pdsc_reset_prepare() called pci_release_regions() unconditionally, but only PFs call pci_request_regions() (pdsc_init_pf). On a VF FLR this makes the kernel warn "Trying to free nonexistent resource". Fixes: ffa55858330f ("pds_core: implement pci reset handlers") Reported-by: sashiko-bot <sashiko-bot@kernel.org> Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260804235946.177762-1-nikhil.rao%40amd.com Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com> Link: https://patch.msgid.link/20260901044219.1361466-3-nikhil.rao@amd.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/amd/pds_core/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/amd/pds_core/main.c b/drivers/net/ethernet/amd/pds_core/main.c
index 6e1079f9ba0f..a971c66d36f9 100644
--- a/drivers/net/ethernet/amd/pds_core/main.c
+++ b/drivers/net/ethernet/amd/pds_core/main.c
@@ -517,8 +517,8 @@ static void pdsc_reset_prepare(struct pci_dev *pdev)
mutex_lock(&pdsc->devcmd_lock);
pdsc_unmap_bars(pdsc);
mutex_unlock(&pdsc->devcmd_lock);
+ pci_release_regions(pdev);
}
- pci_release_regions(pdev);
if (pci_is_enabled(pdev))
pci_disable_device(pdev);
pdsc_deferred_dma_free(pdsc);