diff options
| author | Pei Xiao <xiaopei01@kylinos.cn> | 2026-07-20 14:08:44 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-07-28 19:08:35 +0100 |
| commit | 79052a6a6f5b019d24efbbb934f2d77a1db75211 (patch) | |
| tree | 73a9333cd636f06ec15836aebb77399adcdf1228 | |
| parent | 8955fbad8aad32d7e81fc75d23918e0e2cf6c5ef (diff) | |
| download | linux-next-79052a6a6f5b019d24efbbb934f2d77a1db75211.tar.gz linux-next-79052a6a6f5b019d24efbbb934f2d77a1db75211.zip | |
spi: spacemit: drop redundant dev_err_probe() around irq helpers
platform_get_irq() and devm_request_irq() already print an error
message via dev_err_probe() on failure, so wrapping them with
another dev_err_probe() results in duplicate error output.
Return the error code directly instead.
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://patch.msgid.link/119b5f8e3ac68221307cbfcd227dc8546be0eaeb.1784527556.git.xiaopei01@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-spacemit-k1.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-spacemit-k1.c b/drivers/spi/spi-spacemit-k1.c index cd2955949c5c..4348d77ec77c 100644 --- a/drivers/spi/spi-spacemit-k1.c +++ b/drivers/spi/spi-spacemit-k1.c @@ -737,12 +737,12 @@ static int k1_spi_probe(struct platform_device *pdev) drv_data->irq = platform_get_irq(pdev, 0); if (drv_data->irq < 0) - return dev_err_probe(dev, drv_data->irq, "error getting IRQ\n"); + return drv_data->irq; ret = devm_request_irq(dev, drv_data->irq, k1_spi_ssp_isr, IRQF_SHARED, dev_name(dev), drv_data); if (ret < 0) - return dev_err_probe(dev, ret, "error requesting IRQ\n"); + return ret; /* Initialize the host structure, then register it */ host->dev.of_node = dev_of_node(dev); |