diff options
| author | Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net> | 2026-09-01 02:51:10 +0200 |
|---|---|---|
| committer | Jonathan Cameron <jonathan.cameron@oss.qualcomm.com> | 2026-09-05 01:50:52 +0100 |
| commit | 95c6fe9508dac5db18e679f0cb598ff55cda2cb0 (patch) | |
| tree | 40e617ea269eecaee686f4557c80bd00fe057c4b | |
| parent | 6b5856d16c2e9213fd7eed8a4121aa3ad41081b4 (diff) | |
| download | linux-next-95c6fe9508dac5db18e679f0cb598ff55cda2cb0.tar.gz linux-next-95c6fe9508dac5db18e679f0cb598ff55cda2cb0.zip | |
iio: light: stk3310: lower-case the i2c device ID names
The i2c device IDs were introduced in capitals, mirroring the ACPI
_HID entries added by the same commit be9e6229d676 ("iio: light: Add
support for Sensortek STK3310"); at that point the driver enumerated
through ACPI only, with no OF table and no i2c module alias export.
ACPI _HIDs have their own naming rules; i2c device names
conventionally use the lower-case part name, matching the devicetree
compatible suffix.
The spelling is visible: a client instantiated through the i2c sysfs
interface under the lower-case name taken from a compatible string
binds through the OF table's name fallback, but has no firmware node,
so i2c_match_id() is the only way for it to reach driver match data,
and its string comparison is case-sensitive, so the capitals can never
match. Lower-case the names so such clients match the id table, and
receive the per-chip match data a subsequent change attaches to it.
The module aliases follow the rename (i2c:STK3310 becomes
i2c:stk3310), and a sysfs client instantiated under a capitals name no
longer binds.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Assisted-by: Claude:claude-fable-5
Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
| -rw-r--r-- | drivers/iio/light/stk3310.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index 7c8a1d2b2ed0..5b5b6812edc7 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -766,10 +766,10 @@ static DEFINE_SIMPLE_DEV_PM_OPS(stk3310_pm_ops, stk3310_suspend, stk3310_resume); static const struct i2c_device_id stk3310_i2c_id[] = { - { .name = "STK3013" }, - { .name = "STK3310" }, - { .name = "STK3311" }, - { .name = "STK3335" }, + { .name = "stk3013" }, + { .name = "stk3310" }, + { .name = "stk3311" }, + { .name = "stk3335" }, { } }; MODULE_DEVICE_TABLE(i2c, stk3310_i2c_id); |