diff options
| author | Salah Triki <salah.triki@gmail.com> | 2026-09-03 13:27:33 +0100 |
|---|---|---|
| committer | Jonathan Cameron <jonathan.cameron@oss.qualcomm.com> | 2026-09-10 04:39:07 +0100 |
| commit | a7c07602e00596a45de8a4a700af96392953ed38 (patch) | |
| tree | c6e6c933afa75ac1117f1feb0441bd5f816891ca | |
| parent | 4a4b0d75622f7d911c96045b328fe2e88be05072 (diff) | |
| download | linux-next-a7c07602e00596a45de8a4a700af96392953ed38.tar.gz linux-next-a7c07602e00596a45de8a4a700af96392953ed38.zip | |
iio: imu: adis16400: Check return value of spi_setup()
In adis16400_initial_setup(), the return value of spi_setup() was ignored.
If SPI configuration fails, the driver would proceed with the
initialization anyway, leading to undefined behavior or silent failures
during device setup.
Check the return value of spi_setup() and return the error code immediately
if it fails.
Fixes: cd888a17f95f ("staging:iio:adis16400: Use adis library")
Signed-off-by: Salah Triki <salah.triki@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
| -rw-r--r-- | drivers/iio/imu/adis16400.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c index 4842346f9f0c..f51878066b2f 100644 --- a/drivers/iio/imu/adis16400.c +++ b/drivers/iio/imu/adis16400.c @@ -420,7 +420,10 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev) else st->adis.spi->max_speed_hz = ADIS16400_SPI_FAST; st->adis.spi->mode = SPI_MODE_3; - spi_setup(st->adis.spi); + + ret = spi_setup(st->adis.spi); + if (ret) + return ret; ret = __adis_initial_startup(&st->adis); if (ret) |