summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXu Rao <raoxu@uniontech.com>2026-07-24 17:54:37 +0800
committerSebastian Reichel <sebastian.reichel@collabora.com>2026-07-25 01:08:42 +0200
commitaf4ee48a09cfb7a2440cc4822e9fda43a76cfbe5 (patch)
treecb13ab20114b5ce7d00f1b59c985c31632e9a01e
parentb7c8d46411317f135e7791c0eddc56691de63f07 (diff)
downloadlinux-next-af4ee48a09cfb7a2440cc4822e9fda43a76cfbe5.tar.gz
linux-next-af4ee48a09cfb7a2440cc4822e9fda43a76cfbe5.zip
power: supply: pf1550: enable charging when battery profile exists
PF1550 starts in charger mode 1, where charging is disabled. The driver comment says that mode 2 should be selected for applications using a battery, but the condition is inverted: PF1550_CHG_BAT_ON is written only when power_supply_get_battery_info() fails. Consequently, a board with a valid monitored-battery profile is left in the default charger-off mode, while a board without battery information enables charging with fallback settings. Select mode 2 when battery information is available. Fixes: 4b6b6433a97d ("power: supply: pf1550: add battery charger support") Cc: stable@vger.kernel.org Signed-off-by: Xu Rao <raoxu@uniontech.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/097F0559A936ACCB+20260724095437.368905-1-raoxu@uniontech.com Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-rw-r--r--drivers/power/supply/pf1550-charger.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/pf1550-charger.c b/drivers/power/supply/pf1550-charger.c
index 94fe81bab5a2..2ead1df60e65 100644
--- a/drivers/power/supply/pf1550-charger.c
+++ b/drivers/power/supply/pf1550-charger.c
@@ -514,7 +514,7 @@ static int pf1550_reg_init(struct pf1550_charger *chg)
* a battery. The other supported mode is mode 2, the charger is turned
* on to charge a battery when present.
*/
- if (power_supply_get_battery_info(chg->charger, &info)) {
+ if (!power_supply_get_battery_info(chg->charger, &info)) {
ret = regmap_write(chg->pf1550->regmap,
PF1550_CHARG_REG_CHG_OPER,
PF1550_CHG_BAT_ON);