diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2026-07-15 21:16:03 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2026-07-30 14:33:15 +0100 |
| commit | b1eb3de64d02cec71b419b9918d1697797fa156d (patch) | |
| tree | 72f11b7889ea0f0112c0d5185187569219062b6f | |
| parent | a764e2a617592e5b0cb7646d81973ad765569b3a (diff) | |
| download | linux-next-b1eb3de64d02cec71b419b9918d1697797fa156d.tar.gz linux-next-b1eb3de64d02cec71b419b9918d1697797fa156d.zip | |
mfd: si476x-i2c: Get rid of duplicate NULL checks
GPIO descriptor APIs are NULL-aware and since the requested line is optional
we don't need to have an additional check each time we want to toggle GPIO.
Get rid of duplicate NULL checks.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20260715191603.1325479-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/si476x-i2c.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c index 55700ce711f4..9bce720a0a08 100644 --- a/drivers/mfd/si476x-i2c.c +++ b/drivers/mfd/si476x-i2c.c @@ -130,8 +130,7 @@ int si476x_core_start(struct si476x_core *core, bool soft) int err; if (!soft) { - if (core->reset) - gpiod_set_value_cansleep(core->reset, 0); + gpiod_set_value_cansleep(core->reset, 0); if (client->irq) enable_irq(client->irq); @@ -197,8 +196,7 @@ disable_irq: else cancel_delayed_work_sync(&core->status_monitor); - if (core->reset) - gpiod_set_value_cansleep(core->reset, 1); + gpiod_set_value_cansleep(core->reset, 1); return err; } @@ -242,10 +240,9 @@ int si476x_core_stop(struct si476x_core *core, bool soft) else cancel_delayed_work_sync(&core->status_monitor); - if (!soft) { - if (core->reset) - gpiod_set_value_cansleep(core->reset, 1); - } + if (!soft) + gpiod_set_value_cansleep(core->reset, 1); + return err; } EXPORT_SYMBOL_GPL(si476x_core_stop); |