diff options
| author | Leonardo Martins Martins <dev.lmmrtns@gmail.com> | 2026-09-03 02:18:09 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-09-07 18:25:24 +0200 |
| commit | b5d8eb5d1f82d91cceb537a74780f619bc97ab62 (patch) | |
| tree | 0a88eb47435249c5bacc1c873921a695908d9fab | |
| parent | 01f505c93457b72e2b7698091b68eca9744d9851 (diff) | |
| download | linux-next-b5d8eb5d1f82d91cceb537a74780f619bc97ab62.tar.gz linux-next-b5d8eb5d1f82d91cceb537a74780f619bc97ab62.zip | |
staging: rtl8723bs: remove invariant parameters from _issue_probereq()
The parameters ch and wait_ack in _issue_probereq() are always 0 and
false respectively, remove them and remove unreachable code that depends
on them not being these values.
Signed-off-by: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
Link: https://patch.msgid.link/20260903-issue_probereq-v1-3-82f153d157a1@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index d3c87d25fab1..b3642c5021a2 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -2401,9 +2401,8 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p dump_mgntframe(padapter, pmgntframe); } -static void _issue_probereq(struct adapter *padapter, - struct ndis_802_11_ssid *pssid, - u8 *da, u8 ch, bool append_wps, bool wait_ack) +static void _issue_probereq(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u8 *da, + bool append_wps) { struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; @@ -2468,9 +2467,6 @@ static void _issue_probereq(struct adapter *padapter, pframe = rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, bssrate_len, bssrate, &(pattrib->pktlen)); } - if (ch) - pframe = rtw_set_ie(pframe, WLAN_EID_DS_PARAMS, 1, &ch, &pattrib->pktlen); - if (append_wps) { /* add wps_ie for wps2.0 */ if (pmlmepriv->wps_probe_req_ie_len > 0 && pmlmepriv->wps_probe_req_ie) { @@ -2482,21 +2478,17 @@ static void _issue_probereq(struct adapter *padapter, pattrib->last_txcmdsz = pattrib->pktlen; - if (wait_ack) { - dump_mgntframe_and_wait_ack(padapter, pmgntframe); - } else { - dump_mgntframe(padapter, pmgntframe); - } + dump_mgntframe(padapter, pmgntframe); } inline void issue_probereq(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u8 *da) { - _issue_probereq(padapter, pssid, da, 0, 1, false); + _issue_probereq(padapter, pssid, da, 1); } void issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u8 *da) { - _issue_probereq(padapter, pssid, da, 0, 0, false); + _issue_probereq(padapter, pssid, da, 0); } /* if psta == NULL, indicate we are station(client) now... */ |