diff options
| author | bui duc phuc <phucduc.bui@gmail.com> | 2026-09-03 14:57:53 +0700 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-09-08 15:14:36 +0200 |
| commit | bf6f89ccd9748d895fa861da0edaccb9194e41be (patch) | |
| tree | fd58d7e7bd948e466cc7ad5849628881a1bb2767 | |
| parent | 73db35350c5e1cadb47e9b65633539469e1c5c5a (diff) | |
| download | linux-next-bf6f89ccd9748d895fa861da0edaccb9194e41be.tar.gz linux-next-bf6f89ccd9748d895fa861da0edaccb9194e41be.zip | |
net: mvpp2: simplify IRQ validity check
irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
The current condition also checks for negative values, even though
irq_of_parse_and_map() does not return negative error codes.
Check only for a zero return value to match the semantics of
irq_of_parse_and_map().
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260903075753.346647-1-phucduc.bui@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index ccc24a1301f2..1c50174c9f1e 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -5874,7 +5874,7 @@ static int mvpp2_simple_queue_vectors_init(struct mvpp2_port *port, v->sw_thread_mask = *cpumask_bits(cpu_online_mask); v->port = port; v->irq = irq_of_parse_and_map(port_node, 0); - if (v->irq <= 0) + if (!v->irq) return -EINVAL; netif_napi_add(port->dev, &v->napi, mvpp2_poll); |