summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2026-07-29 10:37:32 +0200
committerTakashi Iwai <tiwai@suse.de>2026-07-31 12:44:36 +0200
commitcefb2f905bb13aea37e5cbab179b602c5817a1c3 (patch)
treea1be86fec5ddfa2d7df1a60ffba778538b33c268
parent26c602eea1f8ac9154c44e5e206f35335f16e025 (diff)
downloadlinux-next-cefb2f905bb13aea37e5cbab179b602c5817a1c3.tar.gz
linux-next-cefb2f905bb13aea37e5cbab179b602c5817a1c3.zip
ALSA: sh: Use auto-cleanup for firmware loading
Simplify the code to manage the firmware loading with __free(firmware) auto-cleanup. Only the code refactoring, no functional changes. Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://patch.msgid.link/20260729083735.120219-15-tiwai@suse.de
-rw-r--r--sound/sh/aica.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 8196e1bf0416..078fc7fc08f9 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -518,8 +518,9 @@ static const struct snd_kcontrol_new snd_aica_pcmvolume_control = {
static int load_aica_firmware(void)
{
int err;
- const struct firmware *fw_entry;
spu_reset();
+
+ const struct firmware *fw_entry __free(firmware) = NULL;
err = request_firmware(&fw_entry, "aica_firmware.bin", &pd->dev);
if (unlikely(err))
return err;
@@ -527,7 +528,6 @@ static int load_aica_firmware(void)
spu_disable();
spu_memload(0, fw_entry->data, fw_entry->size);
spu_enable();
- release_firmware(fw_entry);
return err;
}