diff options
| author | Jori Koolstra <jkoolstra@xs4all.nl> | 2026-06-30 12:53:37 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-07-01 12:49:36 +0200 |
| commit | 3a48f5f81af24fbf2fb5c540cb0cd1826445408a (patch) | |
| tree | 58f79a67a67690206d1991e26d1c20d2fcb940b1 | |
| parent | 5c39d53bf5c3967b1b64ea310ddd1d42a8cc365e (diff) | |
| download | linux-stable-3a48f5f81af24fbf2fb5c540cb0cd1826445408a.tar.gz linux-stable-3a48f5f81af24fbf2fb5c540cb0cd1826445408a.zip | |
ext2: drop redundant S_IFDIR from mkdir
vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to
->mkdir(), so OR-ing S_IFDIR into the mode again in ext2_mkdir() is
redundant. Drop it.
Assisted-by: LLM
Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl>
Link: https://patch.msgid.link/20260630105400.68459-9-jkoolstra@xs4all.nl
Reviewed-by: NeilBrown <neil@brown.name>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
| -rw-r--r-- | fs/ext2/namei.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c index 0d09d22fe708..411fd09c3c7e 100644 --- a/fs/ext2/namei.c +++ b/fs/ext2/namei.c @@ -236,7 +236,7 @@ static struct dentry *ext2_mkdir(struct mnt_idmap * idmap, inode_inc_link_count(dir); - inode = ext2_new_inode(dir, S_IFDIR | mode, &dentry->d_name); + inode = ext2_new_inode(dir, mode, &dentry->d_name); err = PTR_ERR(inode); if (IS_ERR(inode)) goto out_dir; |