summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>2026-05-14 13:54:37 +0530
committerHelge Deller <deller@gmx.de>2026-06-07 18:25:42 +0200
commit3b0ed04bc852887a9164e1bbf521652e8ef3eb92 (patch)
tree565d823fc0072814d9e94d1a96434ef23eeceee2
parent85f5e38c162bdf9dbbe197275d416402712f3707 (diff)
downloadlinux-stable-3b0ed04bc852887a9164e1bbf521652e8ef3eb92.tar.gz
linux-stable-3b0ed04bc852887a9164e1bbf521652e8ef3eb92.zip
fbdev: s3fb: fix potential memory leak in s3_pci_probe()
In s3_pci_probe(), the memory allocated for modelist using fb_videomode_to_modelist() is not freed in subsequent error paths. Fix that by calling fb_destroy_modelist() Fixes: 86c0f043a737 ("s3fb: add DDC support") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in> Signed-off-by: Helge Deller <deller@gmx.de>
-rw-r--r--drivers/video/fbdev/s3fb.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c
index 831e9e6861b1..dc1f9b627185 100644
--- a/drivers/video/fbdev/s3fb.c
+++ b/drivers/video/fbdev/s3fb.c
@@ -1446,6 +1446,7 @@ err_reg_fb:
err_alloc_cmap:
err_find_mode:
#ifdef CONFIG_FB_S3_DDC
+ fb_destroy_modelist(&info->modelist);
if (par->ddc_registered)
i2c_del_adapter(&par->ddc_adapter);
if (par->mmio)