summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Hung <alex.hung@amd.com>2026-06-15 17:10:40 -0600
committerAlex Deucher <alexander.deucher@amd.com>2026-07-01 11:37:01 -0400
commit682710244fa3176f642eecd4c1a27e69be2e3a7f (patch)
tree20c80406974f53fc1c7c7e888d0aab804d90ed6e
parente5316b76d31c93d9204e987a85bdbf1dce08a9cf (diff)
downloadlinux-stable-682710244fa3176f642eecd4c1a27e69be2e3a7f.tar.gz
linux-stable-682710244fa3176f642eecd4c1a27e69be2e3a7f.zip
drm/amd/display: Add KUnit test for amdgpu_dm_wb
[WHAT] Add KUnit test with DRM mock for amdgpu_dm_wb_connector_init(). Assisted-by: Copilot:GPT-5.5 Reviewed-by: Bhawanpreet Lakha <bhawanpreet.lakha@amd.com> Signed-off-by: Alex Hung <alex.hung@amd.com> Signed-off-by: George Zhang <george.zhang@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c1
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c70
2 files changed, 71 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
index 058d478a073d..0bf82e46f773 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
@@ -216,3 +216,4 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display_manager *dm,
return 0;
}
+EXPORT_IF_KUNIT(amdgpu_dm_wb_connector_init);
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c
index b8ad4b87163a..f9a839c10bf4 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c
@@ -16,6 +16,9 @@
#include <drm/drm_modes.h>
#include <drm/drm_writeback.h>
+#include "dc.h"
+#include "amdgpu.h"
+#include "amdgpu_dm.h"
#include "amdgpu_dm_wb.h"
@@ -68,6 +71,23 @@ static struct drm_connector_state *alloc_test_conn_state(struct kunit *test,
return conn_state;
}
+static struct amdgpu_device *alloc_test_adev(struct kunit *test)
+{
+ struct drm_device *drm;
+ struct device *dev;
+
+ dev = drm_kunit_helper_alloc_device(test);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
+
+ drm = __drm_kunit_helper_alloc_drm_device(test, dev,
+ sizeof(struct amdgpu_device),
+ offsetof(struct amdgpu_device, ddev),
+ DRIVER_MODESET | DRIVER_ATOMIC);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm);
+
+ return drm_to_adev(drm);
+}
+
/* Tests for amdgpu_dm_wb_encoder_atomic_check */
/**
@@ -310,6 +330,54 @@ static void dm_test_wb_get_modes_bounded_by_max(struct kunit *test)
}
}
+/* Tests for amdgpu_dm_wb_connector_init using DRM mock */
+
+/**
+ * dm_test_wb_connector_init_success - Verify writeback connector initialization
+ * @test: KUnit test context
+ *
+ * Uses a DRM mock device embedded in struct amdgpu_device to verify that
+ * amdgpu_dm_wb_connector_init() initializes the writeback connector, stores
+ * the DC link, installs connector state through reset, and wires the expected
+ * DRM callbacks.
+ */
+static void dm_test_wb_connector_init_success(struct kunit *test)
+{
+ struct amdgpu_dm_wb_connector *wbcon;
+ struct amdgpu_display_manager *dm;
+ struct amdgpu_device *adev;
+ struct dc_link *link;
+ struct dc *dc;
+ int ret;
+
+ adev = alloc_test_adev(test);
+ adev->mode_info.num_crtc = 1;
+ dm = &adev->dm;
+ dm->adev = adev;
+
+ dc = kunit_kzalloc(test, sizeof(*dc), GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, dc);
+
+ link = kunit_kzalloc(test, sizeof(*link), GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, link);
+
+ dc->links[0] = link;
+ dm->dc = dc;
+
+ wbcon = kunit_kzalloc(test, sizeof(*wbcon), GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, wbcon);
+
+ ret = amdgpu_dm_wb_connector_init(dm, wbcon, 0);
+
+ KUNIT_EXPECT_EQ(test, ret, 0);
+ KUNIT_EXPECT_PTR_EQ(test, wbcon->link, link);
+ KUNIT_EXPECT_TRUE(test, wbcon->base.base.funcs != NULL);
+ KUNIT_EXPECT_TRUE(test, wbcon->base.base.helper_private != NULL);
+ KUNIT_EXPECT_TRUE(test, wbcon->base.base.state != NULL);
+ KUNIT_EXPECT_TRUE(test, wbcon->base.encoder.funcs != NULL);
+ KUNIT_EXPECT_EQ(test, wbcon->base.encoder.possible_crtcs, 0x1);
+}
+
static struct kunit_case dm_wb_test_cases[] = {
/* amdgpu_dm_wb_encoder_atomic_check */
KUNIT_CASE(dm_test_wb_atomic_check_no_job),
@@ -322,6 +390,8 @@ static struct kunit_case dm_wb_test_cases[] = {
/* amdgpu_dm_wb_connector_get_modes */
KUNIT_CASE(dm_test_wb_get_modes_returns_modes),
KUNIT_CASE(dm_test_wb_get_modes_bounded_by_max),
+ /* amdgpu_dm_wb_connector_init */
+ KUNIT_CASE(dm_test_wb_connector_init_success),
{}
};