diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2026-05-18 23:48:50 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2026-06-08 14:53:41 -0400 |
| commit | 967c898d9defb5b6855ea9325eb2dda3b7f06bab (patch) | |
| tree | 98256c836247703d24b4d33c20639d7271c3f1ee | |
| parent | 43b45755e80e5eee9d3f6271d301940af7dbc29b (diff) | |
| download | linux-stable-967c898d9defb5b6855ea9325eb2dda3b7f06bab.tar.gz linux-stable-967c898d9defb5b6855ea9325eb2dda3b7f06bab.zip | |
configfs_create(): lift parent timestamp updates into callers
... and do *not* do it in ->lookup() case. stat foo/bar
should not update mtime of foo, TYVM...
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/configfs/dir.c | 6 | ||||
| -rw-r--r-- | fs/configfs/inode.c | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 4a4bad1741cf..b382d60e7ebc 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -296,6 +296,7 @@ static int configfs_create_dir(struct config_item *item, struct dentry *dentry, int error; umode_t mode = S_IFDIR| S_IRWXU | S_IRUGO | S_IXUGO; struct dentry *p = dentry->d_parent; + struct inode *p_inode = d_inode(p); struct inode *inode; BUG_ON(!item); @@ -316,7 +317,8 @@ static int configfs_create_dir(struct config_item *item, struct dentry *dentry, /* directory inodes start off with i_nlink == 2 (for "." entry) */ inc_nlink(inode); d_make_persistent(dentry, inode); - inc_nlink(d_inode(p)); + inc_nlink(p_inode); + inode_set_mtime_to_ts(p_inode, inode_set_ctime_current(p_inode)); item->ci_dentry = dentry; return 0; @@ -370,6 +372,7 @@ int configfs_create_link(struct configfs_dirent *target, struct dentry *parent, int err = 0; umode_t mode = S_IFLNK | S_IRWXUGO; struct configfs_dirent *p = parent->d_fsdata; + struct inode *p_inode = d_inode(parent); struct inode *inode; err = configfs_make_dirent(p, dentry, target, mode, CONFIGFS_ITEM_LINK, @@ -384,6 +387,7 @@ int configfs_create_link(struct configfs_dirent *target, struct dentry *parent, inode->i_link = body; inode->i_op = &configfs_symlink_inode_operations; d_make_persistent(dentry, inode); + inode_set_mtime_to_ts(p_inode, inode_set_ctime_current(p_inode)); return 0; out_remove: diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c index 3c26b6c443be..68290fe0e374 100644 --- a/fs/configfs/inode.c +++ b/fs/configfs/inode.c @@ -157,7 +157,6 @@ struct inode *configfs_create(struct dentry *dentry, umode_t mode) { struct inode *inode = NULL; struct configfs_dirent *sd; - struct inode *p_inode; if (!dentry) return ERR_PTR(-ENOENT); @@ -170,8 +169,6 @@ struct inode *configfs_create(struct dentry *dentry, umode_t mode) if (!inode) return ERR_PTR(-ENOMEM); - p_inode = d_inode(dentry->d_parent); - inode_set_mtime_to_ts(p_inode, inode_set_ctime_current(p_inode)); configfs_set_inode_lock_class(sd, inode); return inode; } |