diff options
| author | Mika Westerberg <mika.westerberg@linux.intel.com> | 2026-07-28 13:24:27 +0300 |
|---|---|---|
| committer | Mika Westerberg <mika.westerberg@linux.intel.com> | 2026-08-05 05:53:57 +0200 |
| commit | 039701ea3d76ec004863fd7437fb56a9146cb094 (patch) | |
| tree | 397d39ad13f64719748fd44bf90428808acc3cb9 | |
| parent | 41365e558e447cc012ad7a6984f55054323fc63c (diff) | |
| download | linux-039701ea3d76ec004863fd7437fb56a9146cb094.tar.gz linux-039701ea3d76ec004863fd7437fb56a9146cb094.zip | |
thunderbolt: stream: Restore consumer if copying from iter fails
In tbstream_dev_alloc_tx() if copying data from iterator fails we leave
the consumer pointer as is wasting one entry in the ring. Fix this by
restoring the consumer back in case of failure.
Fixes: 6db21d817b43 ("thunderbolt: Add support for USB4STREAM")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| -rw-r--r-- | drivers/thunderbolt/stream.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/thunderbolt/stream.c b/drivers/thunderbolt/stream.c index 68d81958262e..01763f6184e3 100644 --- a/drivers/thunderbolt/stream.c +++ b/drivers/thunderbolt/stream.c @@ -512,8 +512,10 @@ tbstream_dev_alloc_tx(struct tbstream_dev *sdev, enum tbstream_frame_pdf pdf, dma_sync_single_for_cpu(dma_dev, sf->frame.buffer_phy, size, DMA_TO_DEVICE); if (pdf == TBSTREAM_DATA) { - if (copy_page_from_iter(sf->page, 0, size, from) != size) + if (copy_page_from_iter(sf->page, 0, size, from) != size) { + sdev->tx_ring.cons--; return ERR_PTR(-EFAULT); + } } else { memset(page_address(sf->page), 0, size); } |