diff options
| author | Damon Ding <damon.ding@rock-chips.com> | 2025-09-28 18:37:34 +0800 |
|---|---|---|
| committer | Heiko Stuebner <heiko@sntech.de> | 2025-10-14 14:12:23 +0200 |
| commit | 0dc25a11b8936bb752d6217f9db9857641c3d266 (patch) | |
| tree | db6bbc407c2884562d76596882792675e3fccf6c | |
| parent | a312acdcec57b3955fbf1f3057c13a6d38e4aa2a (diff) | |
| download | linux-0dc25a11b8936bb752d6217f9db9857641c3d266.tar.gz linux-0dc25a11b8936bb752d6217f9db9857641c3d266.zip | |
drm/rockchip: analogix_dp: Apply devm_clk_get_optional() for &rockchip_dp_device.grfclk
The "grf" clock is optional for Rockchip eDP controller(RK3399 needs
while RK3288 and RK3588 do not).
It can make the code more concise to use devm_clk_get_optional()
instead of devm_clk_get() with extra checks.
In addtion, DRM_DEV_ERROR() is replaced by dev_err_probe().
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250928103734.4007257-1-damon.ding@rock-chips.com
| -rw-r--r-- | drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index d30f0983a53a..937f83cf42fc 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -335,15 +335,9 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp) return PTR_ERR(dp->grf); } - dp->grfclk = devm_clk_get(dev, "grf"); - if (PTR_ERR(dp->grfclk) == -ENOENT) { - dp->grfclk = NULL; - } else if (PTR_ERR(dp->grfclk) == -EPROBE_DEFER) { - return -EPROBE_DEFER; - } else if (IS_ERR(dp->grfclk)) { - DRM_DEV_ERROR(dev, "failed to get grf clock\n"); - return PTR_ERR(dp->grfclk); - } + dp->grfclk = devm_clk_get_optional(dev, "grf"); + if (IS_ERR(dp->grfclk)) + return dev_err_probe(dev, PTR_ERR(dp->grfclk), "failed to get grf clock\n"); dp->pclk = devm_clk_get(dev, "pclk"); if (IS_ERR(dp->pclk)) { |