summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMurad Masimov <m.masimov@mt-integration.ru>2025-10-09 17:53:08 +0300
committerSebastian Reichel <sebastian.reichel@collabora.com>2025-11-03 01:01:57 +0100
commit15aca30cc6c69806054b896a2ccf7577239cb878 (patch)
tree6f29eab93dc66c5ceb97732927ceff9d0ab81778
parent8b27fe2d8d2380118c343629175385ff587e2fe4 (diff)
downloadlinux-15aca30cc6c69806054b896a2ccf7577239cb878.tar.gz
linux-15aca30cc6c69806054b896a2ccf7577239cb878.zip
power: supply: rt9467: Prevent using uninitialized local variable in rt9467_set_value_from_ranges()
There is a typo in rt9467_set_value_from_ranges() that can cause leaving local variable sel with an undefined value which is then used in regmap_field_write(). Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver") Signed-off-by: Murad Masimov <m.masimov@mt-integration.ru> Link: https://patch.msgid.link/20251009145308.1830893-1-m.masimov@mt-integration.ru Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-rw-r--r--drivers/power/supply/rt9467-charger.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
index b4917514bd70..44c26fb37a77 100644
--- a/drivers/power/supply/rt9467-charger.c
+++ b/drivers/power/supply/rt9467-charger.c
@@ -376,7 +376,7 @@ static int rt9467_set_value_from_ranges(struct rt9467_chg_data *data,
if (rsel == RT9467_RANGE_VMIVR) {
ret = linear_range_get_selector_high(range, value, &sel, &found);
if (ret)
- value = range->max_sel;
+ sel = range->max_sel;
} else {
linear_range_get_selector_within(range, value, &sel);
}