summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJori Koolstra <jkoolstra@xs4all.nl>2026-06-30 12:53:52 +0200
committerChristian Brauner <brauner@kernel.org>2026-07-01 12:50:52 +0200
commit38d8af9d314da7952f6876a2f5e07fa79bb1c459 (patch)
treef5bd6cd424df6a1708d40fda306003da0202b7cc
parent8f1b4d14e9fc0110b4a22c7dfbc9d3dde6cb60df (diff)
downloadlinux-38d8af9d314da7952f6876a2f5e07fa79bb1c459.tar.gz
linux-38d8af9d314da7952f6876a2f5e07fa79bb1c459.zip
omfs: drop redundant S_IFDIR from mkdir
vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to ->mkdir(), so OR-ing S_IFDIR into the mode again in omfs_mkdir() is redundant. Drop it. Assisted-by: LLM Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl> Link: https://patch.msgid.link/20260630105400.68459-24-jkoolstra@xs4all.nl Reviewed-by: NeilBrown <neil@brown.name> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
-rw-r--r--fs/omfs/dir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/omfs/dir.c b/fs/omfs/dir.c
index 2ed541fccf33..418906614f89 100644
--- a/fs/omfs/dir.c
+++ b/fs/omfs/dir.c
@@ -282,7 +282,7 @@ out_free_inode:
static struct dentry *omfs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
struct dentry *dentry, umode_t mode)
{
- return ERR_PTR(omfs_add_node(dir, dentry, mode | S_IFDIR));
+ return ERR_PTR(omfs_add_node(dir, dentry, mode));
}
static int omfs_create(struct mnt_idmap *idmap, struct inode *dir,