summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJori Koolstra <jkoolstra@xs4all.nl>2026-06-30 12:53:48 +0200
committerChristian Brauner <brauner@kernel.org>2026-07-01 12:50:39 +0200
commit428475b82a4da0dbd5c0091718e059ff85b322a7 (patch)
tree64f64a8075adebc0e047b21b485694ca0ca1a256
parent1ab6211652b42f1a06ddd2beb55cd346cb353268 (diff)
downloadlinux-428475b82a4da0dbd5c0091718e059ff85b322a7.tar.gz
linux-428475b82a4da0dbd5c0091718e059ff85b322a7.zip
nilfs2: drop redundant S_IFDIR from mkdir
vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to ->mkdir(), so OR-ing S_IFDIR into the mode again in nilfs_mkdir() is redundant. Drop it. Assisted-by: LLM Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl> Link: https://patch.msgid.link/20260630105400.68459-20-jkoolstra@xs4all.nl Reviewed-by: NeilBrown <neil@brown.name> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
-rw-r--r--fs/nilfs2/namei.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c
index e2fe95de3d71..d7d4f4d9a4e8 100644
--- a/fs/nilfs2/namei.c
+++ b/fs/nilfs2/namei.c
@@ -231,7 +231,7 @@ static struct dentry *nilfs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
inc_nlink(dir);
- inode = nilfs_new_inode(dir, S_IFDIR | mode);
+ inode = nilfs_new_inode(dir, mode);
err = PTR_ERR(inode);
if (IS_ERR(inode))
goto out_dir;